Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2925903002: [inspector] Make breakpoints active state per-agent (Closed)

Created:
3 years, 6 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Make breakpoints active state per-agent ... as opposite to a global per-isolate one. Also streamlined multiple checks into a single acceptsPause() method. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2925903002 Cr-Commit-Position: refs/heads/master@{#45749} Committed: https://chromium.googlesource.com/v8/v8/+/31662cc3e4552927bffd6b1f9ecf167ea4675a37

Patch Set 1 #

Patch Set 2 : fixed wrong behavior #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -29 lines) Patch
M src/inspector/v8-debugger.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/inspector/v8-debugger.cc View 1 5 chunks +9 lines, -14 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.cc View 1 7 chunks +16 lines, -10 lines 0 comments Download
M test/inspector/sessions/debugger-stepping-and-breakpoints.js View 1 chunk +19 lines, -0 lines 0 comments Download
M test/inspector/sessions/debugger-stepping-and-breakpoints-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (12 generated)
dgozman
Could you please take a look?
3 years, 6 months ago (2017-06-06 18:51:15 UTC) #4
dgozman
Please take a look at new version.
3 years, 6 months ago (2017-06-06 22:39:59 UTC) #9
kozy
lgtm.
3 years, 6 months ago (2017-06-06 22:53:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925903002/20001
3 years, 6 months ago (2017-06-07 00:04:45 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 00:06:17 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/31662cc3e4552927bffd6b1f9ecf167ea46...

Powered by Google App Engine
This is Rietveld 408576698