Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2923243002: [inspector] Return error when paused in different context group (Closed)

Created:
3 years, 6 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Return error when paused in different context group ... when trying to resume or step. BUG=none Review-Url: https://codereview.chromium.org/2923243002 Cr-Commit-Position: refs/heads/master@{#45747} Committed: https://chromium.googlesource.com/v8/v8/+/5852180eb8e58a4b41c8d5bb72c56fdce20f684c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -3 lines) Patch
M src/inspector/v8-debugger.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/inspector/v8-debugger.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/inspector/debugger/pause.js View 1 chunk +17 lines, -0 lines 0 comments Download
M test/inspector/debugger/pause-expected.txt View 1 chunk +33 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
dgozman
Take a look please.
3 years, 6 months ago (2017-06-06 18:00:00 UTC) #2
kozy
Nice, lgtm.
3 years, 6 months ago (2017-06-06 18:02:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923243002/1
3 years, 6 months ago (2017-06-06 18:44:33 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 18:46:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5852180eb8e58a4b41c8d5bb72c56fdce20...

Powered by Google App Engine
This is Rietveld 408576698