Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2925833002: Ensure the NTP ServiceWorker has the proper site URL (Closed)

Created:
3 years, 6 months ago by clamy
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Ensure the NTP ServiceWorker has the proper site URL This CL ensures the ServiceWorker of the NTP gets recognized as such, and that it is assigned the same effective URL as the NTP. This allows it to run in the same process as the NTP when PlzNavigate is enabled, fixing a regression on the PLT of the NTP. BUG=705318 Review-Url: https://codereview.chromium.org/2898313003 Cr-Original-Commit-Position: refs/heads/master@{#475566} Review-Url: https://codereview.chromium.org/2925833002 . Cr-Commit-Position: refs/branch-heads/3112@{#179} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/8d60a32d7e2aa25fef5daf100bfa49990672fc6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M chrome/browser/search/search.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/search/search_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/search/search_urls.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/search/search_urls.cc View 3 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
clamy
3 years, 6 months ago (2017-06-06 12:56:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d60a32d7e2aa25fef5daf100bfa49990672fc6d.

Powered by Google App Engine
This is Rietveld 408576698