Ensure the NTP ServiceWorker has the proper site URL

Ensure the NTP ServiceWorker has the proper site URL

This CL ensures the ServiceWorker of the NTP gets recognized as such,
and that it is assigned the same effective URL as the NTP. This allows
it to run in the same process as the NTP when PlzNavigate is enabled,
fixing a regression on the PLT of the NTP.

BUG=705318
Review-Url: https://codereview.chromium.org/2898313003
Cr-Commit-Position: refs/heads/master@{#475566}
Committed: https://chromium.googlesource.com/chromium/src/+/a4262ab9315b24197a00cc6c942474144c1e4a7f

[clamy, 2017-05-24 17:16:14]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 17:16:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 18:20:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 18:20:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[clamy, 2017-05-29 15:31:30]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 15:31:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2017-05-29 16:03:10]

Description was changed from

==========
Ensure the NTP ServiceWorker has the proper site URL

This CL ensures the ServiceWorker of the NTP gets recognized as such,
and that it is assigned the same effective URL as the NTP. This allows
it ot run in the same process as the NTP when PlzNavigate is enabled,
fixing a regression on the PLT of the NTP.

BUG=705318
==========

to

==========
Ensure the NTP ServiceWorker has the proper site URL

This CL ensures the ServiceWorker of the NTP gets recognized as such,
and that it is assigned the same effective URL as the NTP. This allows
it ot run in the same process as the NTP when PlzNavigate is enabled,
fixing a regression on the PLT of the NTP.

BUG=705318
==========

[clamy, 2017-05-29 16:03:10]

clamy@chromium.org changed reviewers:
+ jam@chromium.org

[clamy, 2017-05-29 16:03:54]

@jam: PTAL (the owner for this code is OOO until June 7).

[commit-bot: I haz the power, 2017-05-29 16:15:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 16:15:09]

Dry run: This issue passed the CQ dry run.

[jam, 2017-05-30 14:38:27]

Description was changed from

==========
Ensure the NTP ServiceWorker has the proper site URL

This CL ensures the ServiceWorker of the NTP gets recognized as such,
and that it is assigned the same effective URL as the NTP. This allows
it ot run in the same process as the NTP when PlzNavigate is enabled,
fixing a regression on the PLT of the NTP.

BUG=705318
==========

to

==========
Ensure the NTP ServiceWorker has the proper site URL

This CL ensures the ServiceWorker of the NTP gets recognized as such,
and that it is assigned the same effective URL as the NTP. This allows
it to run in the same process as the NTP when PlzNavigate is enabled,
fixing a regression on the PLT of the NTP.

BUG=705318
==========

[jam, 2017-05-30 14:51:12]

lgtm

https://codereview.chromium.org/2898313003/diff/20001/chrome/common/search/se...
File chrome/common/search/search_urls.h (right):

https://codereview.chromium.org/2898313003/diff/20001/chrome/common/search/se...
chrome/common/search/search_urls.h:19: bool IsMatchingServiceWorker(const GURL&
my_url, const GURL& other_url);
nit: document

[clamy, 2017-05-30 15:54:11]

Thanks!

https://codereview.chromium.org/2898313003/diff/20001/chrome/common/search/se...
File chrome/common/search/search_urls.h (right):

https://codereview.chromium.org/2898313003/diff/20001/chrome/common/search/se...
chrome/common/search/search_urls.h:19: bool IsMatchingServiceWorker(const GURL&
my_url, const GURL& other_url);
On 2017/05/30 14:51:11, jam wrote:
> nit: document

Done.

[clamy, 2017-05-30 15:54:16]

The CQ bit was checked by clamy@chromium.org

[clamy, 2017-05-30 15:54:16]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2898313003/#ps40001
(title: "Rebase + addressed comments")

[commit-bot: I haz the power, 2017-05-30 15:54:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-05-30 16:12:41]

https://codereview.chromium.org/2898313003/diff/20001/chrome/common/search/se...
File chrome/common/search/search_urls.h (right):

https://codereview.chromium.org/2898313003/diff/20001/chrome/common/search/se...
chrome/common/search/search_urls.h:19: bool IsMatchingServiceWorker(const GURL&
my_url, const GURL& other_url);
On 2017/05/30 14:51:11, jam wrote:
> nit: document

sorry I wasn't clear, I meant document this method

[commit-bot: I haz the power, 2017-05-30 16:53:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496159656121850,
"parent_rev": "bb1830f1f2f36ecd8dda3b42bfe5302fd8321a0c", "commit_rev":
"a4262ab9315b24197a00cc6c942474144c1e4a7f"}

[commit-bot: I haz the power, 2017-05-30 16:53:39]

Description was changed from

==========
Ensure the NTP ServiceWorker has the proper site URL

This CL ensures the ServiceWorker of the NTP gets recognized as such,
and that it is assigned the same effective URL as the NTP. This allows
it to run in the same process as the NTP when PlzNavigate is enabled,
fixing a regression on the PLT of the NTP.

BUG=705318
==========

to

==========
Ensure the NTP ServiceWorker has the proper site URL

This CL ensures the ServiceWorker of the NTP gets recognized as such,
and that it is assigned the same effective URL as the NTP. This allows
it to run in the same process as the NTP when PlzNavigate is enabled,
fixing a regression on the PLT of the NTP.

BUG=705318

Review-Url: https://codereview.chromium.org/2898313003
Cr-Commit-Position: refs/heads/master@{#475566}
Committed:
https://chromium.googlesource.com/chromium/src/+/a4262ab9315b24197a00cc6c9424...
==========

[commit-bot: I haz the power, 2017-05-30 16:53:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a4262ab9315b24197a00cc6c9424...