Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2925803002:
Uncomment test fbs files. (Closed)
|
Created:
3 years, 6 months ago by pkalinnikov Modified:
3 years, 6 months ago Reviewers:
battre CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUncomment test fbs files.
This CL ensures that crbug/611351 has been fixed in crrev/2883063002.
BUG=611351
Review-Url: https://codereview.chromium.org/2925803002
Cr-Commit-Position: refs/heads/master@{#478061}
Committed: https://chromium.googlesource.com/chromium/src/+/35b1f087f6c61741160807549ff9051fb4d015e0
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 21 (16 generated)
The CQ bit was checked by pkalinnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Uncomment test fbs files. BUG=611351 ========== to ========== Uncomment test fbs files. This CL ensures that crug/611351 has been fixed in crrev/2883063002. BUG=611351 ==========
pkalinnikov@chromium.org changed reviewers: + battre@chromium.org
Dominic, PTAL.
Description was changed from ========== Uncomment test fbs files. This CL ensures that crug/611351 has been fixed in crrev/2883063002. BUG=611351 ========== to ========== Uncomment test fbs files. This CL ensures that crbug/611351 has been fixed in crrev/2883063002. BUG=611351 ==========
\o/ LGTM, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by pkalinnikov@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by pkalinnikov@chromium.org
The CQ bit was checked by pkalinnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by pkalinnikov@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496939751954840, "parent_rev":
"2a2b0e095d59c093b3862f81c7daabb0a4e79d7f", "commit_rev":
"35b1f087f6c61741160807549ff9051fb4d015e0"}
Message was sent while issue was closed.
Description was changed from ========== Uncomment test fbs files. This CL ensures that crbug/611351 has been fixed in crrev/2883063002. BUG=611351 ========== to ========== Uncomment test fbs files. This CL ensures that crbug/611351 has been fixed in crrev/2883063002. BUG=611351 Review-Url: https://codereview.chromium.org/2925803002 Cr-Commit-Position: refs/heads/master@{#478061} Committed: https://chromium.googlesource.com/chromium/src/+/35b1f087f6c61741160807549ff9... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/35b1f087f6c61741160807549ff9... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
