Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2925763002: color: Enable color correct rendering for images/ layout tests (Closed)

Created:
3 years, 6 months ago by ccameron
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Enable color correct rendering for images/ layout tests Apply this to GPU rasterization. Force all platforms to use sRGB as their color space. A separate virtual test suite will be added to test more exotic color spaces. TBR=qyearsley BUG=713891 Review-Url: https://codereview.chromium.org/2925763002 Cr-Commit-Position: refs/heads/master@{#477433} Committed: https://chromium.googlesource.com/chromium/src/+/711ff9d774dd4812e735be0bcd6b548851a75360

Patch Set 1 #

Patch Set 2 : Update test expectations #

Patch Set 3 : Remove extra changes #

Patch Set 4 : Add two more test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -116 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +13 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +3 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-animate-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-animate-rotate-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-repeat-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-fade-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-image-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-border-radius-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-clip-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-filter-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-iframe-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-object-fit-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-pseudo-content-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-shape-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-image-svg-resource-url-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-object-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-svg-foreign-object-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/jpeg-with-color-profile-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/png-suite/test-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/png-with-color-profile-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/webp-color-profile-lossless-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/webp-color-profile-lossy-alpha-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/webp-color-profile-lossy-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-layer-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu-rasterization/images/color-profile-clip-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/images/color-profile-clip-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cHRM_color_spin-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-jpeg-with-color-profile-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-animate-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-animate-rotate-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-repeat-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-border-fade-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-border-image-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-border-image-source-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-border-radius-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-drag-image-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-filter-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-iframe-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-object-fit-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-profile-match-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-pseudo-content-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-shape-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-image-svg-resource-url-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.txt View 1 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-munsell-srgb-to-srgb-expected.txt View 1 1 chunk +25 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-object-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-svg-foreign-object-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/embed-image-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/jpeg-with-color-profile-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/object-image-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/paint-subrect-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/paletted-png-with-color-profile-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/png-color-profile-ignore-gamma-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/png-suite/test-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/png-with-color-profile-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/png_per_row_alpha_decoding-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/webp-color-profile-lossless-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/webp-color-profile-lossy-alpha-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/webp-color-profile-lossy-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cHRM_color_spin-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-jpeg-with-color-profile-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-animate-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-animate-rotate-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-repeat-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-border-fade-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-border-image-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-border-radius-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-clip-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-filter-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-iframe-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-pattern-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-canvas-svg-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-object-fit-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-pseudo-content-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-shape-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-image-svg-resource-url-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-munsell-adobe-to-srgb-expected.txt View 1 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-object-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-svg-foreign-object-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/jpeg-with-color-profile-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/paletted-png-with-color-profile-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/png-color-profile-ignore-gamma-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/png-suite/test-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/png-with-color-profile-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/webp-color-profile-lossless-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/webp-color-profile-lossy-alpha-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/webp-color-profile-lossy-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/cHRM_color_spin-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/color-jpeg-with-color-profile-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/cross-fade-overflow-position-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/cross-fade-tiled-expected.png View 1 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/paletted-png-with-color-profile-expected.png View 1 Binary file 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925763002/40001
3 years, 6 months ago (2017-06-06 19:30:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925763002/60001
3 years, 6 months ago (2017-06-06 20:40:58 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 22:19:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/711ff9d774dd4812e735be0bcd6b...

Powered by Google App Engine
This is Rietveld 408576698