Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2925623003: color: Remove unneeded ColorBehavior parameters from ImageSource (Closed)

Created:
3 years, 6 months ago by ccameron
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, Rik, Justin Novosad, blink-reviews, kinuko+watch, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Remove unneeded ColorBehavior parameters from ImageSource This is no longer needed, now that we're not supporting parameterizing the ColorBehavior for images. This was also causing crashes (presumably because re-creating the decoder could sometimes fail). TBR=junov BUG=729912 Review-Url: https://codereview.chromium.org/2925623003 Cr-Commit-Position: refs/heads/master@{#477223} Committed: https://chromium.googlesource.com/chromium/src/+/d27758dcb7026312da955a8ba8d01fbaf925882a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -31 lines) Patch
M third_party/WebKit/Source/platform/graphics/BitmapImage.cpp View 3 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageSource.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageSource.cpp View 3 chunks +8 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925623003/1
3 years, 6 months ago (2017-06-06 05:14:57 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 07:04:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d27758dcb7026312da955a8ba8d0...

Powered by Google App Engine
This is Rietveld 408576698