Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 2925703002: Explicitly set story names for service_worker benchmark stories (Closed)

Created:
3 years, 6 months ago by ashleymarie1
Modified:
3 years, 6 months ago
Reviewers:
nednguyen, horo
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly set story names for service_worker benchmark stories BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2925703002 Cr-Commit-Position: refs/heads/master@{#477277} Committed: https://chromium.googlesource.com/chromium/src/+/2921dc4ba79e6dd8d8f0ab2f5fa710cf82e0ffe8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tools/perf/page_sets/service_worker.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/service_worker_micro_benchmark.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ashleymarie1
3 years, 6 months ago (2017-06-05 20:36:39 UTC) #2
nednguyen
lgtm
3 years, 6 months ago (2017-06-05 20:48:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925703002/1
3 years, 6 months ago (2017-06-05 20:52:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/310759)
3 years, 6 months ago (2017-06-06 01:01:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925703002/1
3 years, 6 months ago (2017-06-06 13:18:02 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 14:08:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2921dc4ba79e6dd8d8f0ab2f5fa7...

Powered by Google App Engine
This is Rietveld 408576698