Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: tools/perf/page_sets/service_worker.py

Issue 2925703002: Explicitly set story names for service_worker benchmark stories (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/service_worker_micro_benchmark.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.page import page as page 5 from telemetry.page import page as page
6 from telemetry import story 6 from telemetry import story
7 7
8 8
9 archive_data_file_path = 'data/service_worker.json' 9 archive_data_file_path = 'data/service_worker.json'
10 10
11 11
12 class ServiceWorkerPageSet(story.StorySet): 12 class ServiceWorkerPageSet(story.StorySet):
13 """Page set of applications using ServiceWorker""" 13 """Page set of applications using ServiceWorker"""
14 14
15 def __init__(self): 15 def __init__(self):
16 super(ServiceWorkerPageSet, self).__init__( 16 super(ServiceWorkerPageSet, self).__init__(
17 archive_data_file=archive_data_file_path, 17 archive_data_file=archive_data_file_path,
18 cloud_storage_bucket=story.PARTNER_BUCKET) 18 cloud_storage_bucket=story.PARTNER_BUCKET,
19 verify_names=True)
19 20
20 # Why: the first application using ServiceWorker 21 # Why: the first application using ServiceWorker
21 # 1st time: registration 22 # 1st time: registration
22 self.AddStory(page.Page( 23 self.AddStory(page.Page(
23 'https://jakearchibald.github.io/trained-to-thrill/', self, 24 'https://jakearchibald.github.io/trained-to-thrill/', self,
24 name='first_load', make_javascript_deterministic=False)) 25 name='first_load', make_javascript_deterministic=False))
25 # 2nd time: 1st onfetch with caching 26 # 2nd time: 1st onfetch with caching
26 self.AddStory(page.Page( 27 self.AddStory(page.Page(
27 'https://jakearchibald.github.io/trained-to-thrill/', self, 28 'https://jakearchibald.github.io/trained-to-thrill/', self,
28 name='second_load', make_javascript_deterministic=False)) 29 name='second_load', make_javascript_deterministic=False))
29 # 3rd time: 2nd onfetch from cache 30 # 3rd time: 2nd onfetch from cache
30 self.AddStory(page.Page( 31 self.AddStory(page.Page(
31 'https://jakearchibald.github.io/trained-to-thrill/', self, 32 'https://jakearchibald.github.io/trained-to-thrill/', self,
32 name='third_load', make_javascript_deterministic=False)) 33 name='third_load', make_javascript_deterministic=False))
33 34
34 # Why: another caching strategy: cache.addAll in oninstall handler 35 # Why: another caching strategy: cache.addAll in oninstall handler
35 # 1st time: registration and caching 36 # 1st time: registration and caching
36 self.AddStory(page.Page( 37 self.AddStory(page.Page(
37 'https://jakearchibald.github.io/svgomg/', self, 38 'https://jakearchibald.github.io/svgomg/', self,
38 name='svgomg_first_load', make_javascript_deterministic=False)) 39 name='svgomg_first_load', make_javascript_deterministic=False))
39 # 2nd time: onfetch from cache 40 # 2nd time: onfetch from cache
40 self.AddStory(page.Page( 41 self.AddStory(page.Page(
41 'https://jakearchibald.github.io/svgomg/', self, 42 'https://jakearchibald.github.io/svgomg/', self,
42 name='svgomg_second_load', make_javascript_deterministic=False)) 43 name='svgomg_second_load', make_javascript_deterministic=False))
OLDNEW
« no previous file with comments | « no previous file | tools/perf/page_sets/service_worker_micro_benchmark.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698