[ActiveSuggestionMarker #3] Add painting for ActiveSuggestionMarker

Add painting for ActiveSuggestionMarker

This MarkerType was added in https://codereview.chromium.org/2923033002, but
that CL did not include code to actually paint this new type of marker. This CL
makes ActiveSuggestionMarkers be painted the same way as CompositionMarkers and
adds layout tests (copied from the existing ones for CompositionMarker) to
verify this.

BUG=715365
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2925543003
Cr-Commit-Position: refs/heads/master@{#477485}
Committed: https://chromium.googlesource.com/chromium/src/+/a1166ddba7050dd957ca5e0f5e14ce05afd4b0ff

[rlanday, 2017-06-05 20:33:18]

Description was changed from

==========
Add painting for ActiveSuggestionMarker

This MarkerType was added in https://codereview.chromium.org/2923033002, but
that CL did not include code to actually paint this new type of marker. This CL
makes ActiveSuggestionMarkers be painted the same way as CompositionMarkers and
adds layout tests (copied from the existing ones for CompositionMarker) to
verify this.

BUG=715365
==========

to

==========
Add painting for ActiveSuggestionMarker

This MarkerType was added in https://codereview.chromium.org/2923033002, but
that CL did not include code to actually paint this new type of marker. This CL
makes ActiveSuggestionMarkers be painted the same way as CompositionMarkers and
adds layout tests (copied from the existing ones for CompositionMarker) to
verify this.

BUG=715365
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rlanday, 2017-06-06 00:26:46]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[yosin_UTC9, 2017-06-06 01:31:22]

yosin@chromium.org changed reviewers:
+ chrishtr@chromium.org

[yosin_UTC9, 2017-06-06 01:31:23]

non-ownere lgtm

+chrishtr@ for core/paint

https://codereview.chromium.org/2925543003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp (right):

https://codereview.chromium.org/2925543003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp:680: const
StyleableMarker& marker_with_formatting =
Is it better to use |stylable_marker| instead of |maker_with_formatting|?

[rlanday, 2017-06-06 01:52:49]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-06-06 01:53:02]

On 2017/06/06 at 01:31:23, yosin wrote:
> non-ownere lgtm
> 
> +chrishtr@ for core/paint
> 
>
https://codereview.chromium.org/2925543003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp (right):
> 
>
https://codereview.chromium.org/2925543003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp:680: const
StyleableMarker& marker_with_formatting =
> Is it better to use |stylable_marker| instead of |maker_with_formatting|?

Indeed. Updated

[commit-bot: I haz the power, 2017-06-06 01:53:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 04:46:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 04:46:28]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2017-06-06 23:36:07]

lgtm

[rlanday, 2017-06-07 00:22:13]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-06-07 00:22:14]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2925543003/#ps60001
(title: "marker_with_formatting => styleable_marker")

[commit-bot: I haz the power, 2017-06-07 00:22:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 00:27:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496794933950420,
"parent_rev": "1bec107da00dbd9dccb047655806d0d03f26ba8f", "commit_rev":
"a1166ddba7050dd957ca5e0f5e14ce05afd4b0ff"}

[commit-bot: I haz the power, 2017-06-07 00:27:12]

Description was changed from

==========
Add painting for ActiveSuggestionMarker

This MarkerType was added in https://codereview.chromium.org/2923033002, but
that CL did not include code to actually paint this new type of marker. This CL
makes ActiveSuggestionMarkers be painted the same way as CompositionMarkers and
adds layout tests (copied from the existing ones for CompositionMarker) to
verify this.

BUG=715365
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add painting for ActiveSuggestionMarker

This MarkerType was added in https://codereview.chromium.org/2923033002, but
that CL did not include code to actually paint this new type of marker. This CL
makes ActiveSuggestionMarkers be painted the same way as CompositionMarkers and
adds layout tests (copied from the existing ones for CompositionMarker) to
verify this.

BUG=715365
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2925543003
Cr-Commit-Position: refs/heads/master@{#477485}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1166ddba7050dd957ca5e0f5e14...
==========

[commit-bot: I haz the power, 2017-06-07 00:27:14]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a1166ddba7050dd957ca5e0f5e14...