[ActiveSuggestionMarker #4] Refactor InlineTextBoxPainter to avoid using CompositionUnderline

Refactor InlineTextBoxPainter to avoid using CompositionUnderline

CompositionUnderline is a class that exists mainly so callers can specify the
information necessary for creating CompositionMarkers (start/end offset,
underline color, thickness, background color). It's currently also serving
double-duty in InlineTextBoxPainter to pass this information around after it's
retrieved from a CompositionMarker. With the introduction of painting support
for ActiveSuggestionMarker in https://codereview.chromium.org/2925543003, this
starts to seem kind of strange, if it didn't already (since we're creating
CompositionUnderlines from non-Composition markers). This CL refactors
InlineTextBoxPainter to pass around references to DocumentMarkers/
StyleableMarkers directly instead of creating CompositionUnderlines.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2920373003
Cr-Commit-Position: refs/heads/master@{#480273}
Committed: https://chromium.googlesource.com/chromium/src/+/206f5f0fcdd4809a342fdde6dbcfa24d2dbc306f

[rlanday, 2017-06-06 02:15:25]

Description was changed from

==========
Refactor InlineTextBoxPainter to avoid using CompositionUnderline

CompositionUnderline is a class that exists mainly so callers can specify the
information necessary for creating CompositionMarkers (start/end offset,
underline color, thickness, background color). It's currently also serving
double-duty in InlineTextBoxPainter to pass this information around after it's
retrieved from a CompositionMarker. With the introduction of painting support
for ActiveSuggestionMarker in https://codereview.chromium.org/2925543003, this
starts to seem kind of strange, if it didn't already (since we're creating
CompositionUnderlines from non-Composition markers). This CL refactors
InlineTextBoxPainter to pass around references to DocumentMarkers/
StyleableMarkers directly instead of creating CompositionUnderlines.

BUG=707867
==========

to

==========
Refactor InlineTextBoxPainter to avoid using CompositionUnderline

CompositionUnderline is a class that exists mainly so callers can specify the
information necessary for creating CompositionMarkers (start/end offset,
underline color, thickness, background color). It's currently also serving
double-duty in InlineTextBoxPainter to pass this information around after it's
retrieved from a CompositionMarker. With the introduction of painting support
for ActiveSuggestionMarker in https://codereview.chromium.org/2925543003, this
starts to seem kind of strange, if it didn't already (since we're creating
CompositionUnderlines from non-Composition markers). This CL refactors
InlineTextBoxPainter to pass around references to DocumentMarkers/
StyleableMarkers directly instead of creating CompositionUnderlines.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rlanday, 2017-06-06 02:15:42]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 02:16:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 04:14:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 04:14:36]

Dry run: This issue passed the CQ dry run.

[rlanday, 2017-06-06 19:29:57]

rlanday@chromium.org changed reviewers:
+ chrishtr@chromium.org

[rlanday, 2017-06-06 19:30:28]

Note: this CL is stacked on top of (and depends on)
https://codereview.chromium.org/2925543003

[chrishtr, 2017-06-16 23:07:17]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-06-16 23:07:18]

lgtm

[commit-bot: I haz the power, 2017-06-16 23:07:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 23:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 23:10:55]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[rlanday, 2017-06-17 00:01:40]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-06-17 00:01:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2920373003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-17 00:02:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-17 02:32:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497657700249690,
"parent_rev": "c827628866fdf233d926c6337b32c31ec3871b5a", "commit_rev":
"206f5f0fcdd4809a342fdde6dbcfa24d2dbc306f"}

[commit-bot: I haz the power, 2017-06-17 02:32:15]

Description was changed from

==========
Refactor InlineTextBoxPainter to avoid using CompositionUnderline

CompositionUnderline is a class that exists mainly so callers can specify the
information necessary for creating CompositionMarkers (start/end offset,
underline color, thickness, background color). It's currently also serving
double-duty in InlineTextBoxPainter to pass this information around after it's
retrieved from a CompositionMarker. With the introduction of painting support
for ActiveSuggestionMarker in https://codereview.chromium.org/2925543003, this
starts to seem kind of strange, if it didn't already (since we're creating
CompositionUnderlines from non-Composition markers). This CL refactors
InlineTextBoxPainter to pass around references to DocumentMarkers/
StyleableMarkers directly instead of creating CompositionUnderlines.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Refactor InlineTextBoxPainter to avoid using CompositionUnderline

CompositionUnderline is a class that exists mainly so callers can specify the
information necessary for creating CompositionMarkers (start/end offset,
underline color, thickness, background color). It's currently also serving
double-duty in InlineTextBoxPainter to pass this information around after it's
retrieved from a CompositionMarker. With the introduction of painting support
for ActiveSuggestionMarker in https://codereview.chromium.org/2925543003, this
starts to seem kind of strange, if it didn't already (since we're creating
CompositionUnderlines from non-Composition markers). This CL refactors
InlineTextBoxPainter to pass around references to DocumentMarkers/
StyleableMarkers directly instead of creating CompositionUnderlines.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2920373003
Cr-Commit-Position: refs/heads/master@{#480273}
Committed:
https://chromium.googlesource.com/chromium/src/+/206f5f0fcdd4809a342fdde6dbcf...
==========

[commit-bot: I haz the power, 2017-06-17 02:32:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/206f5f0fcdd4809a342fdde6dbcf...