color: Disable Javascript setColorSpace with color correct rendering

color: Disable Javascript setColorSpace with color correct rendering

Explicitly disable the Javascript setColorSpace API when color correct
rendering is enabled. These functions do (almost) nothing when color
correct rendering is disabled (they raced with something that always
beat it), and they create races with color correct rendering enabled.

The purpose of the JS API is to test different output color spaces, which
we will be doing through virtual test suites, which will remove the
platform dependency and not be racy.

Also don't give Mac a different default color space when using color
correct rendering -- use sRGB across the board.

TBR=avi (for OWNERS)
TBR=enne (for the plan)
BUG=713891
Review-Url: https://codereview.chromium.org/2925473002
Cr-Commit-Position: refs/heads/master@{#476911}
Committed: https://chromium.googlesource.com/chromium/src/+/772317d1eec55c7ef441a39a7349856a3d01ed65

[ccameron, 2017-06-03 22:53:28]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-03 22:53:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-06-04 17:11:54]

Description was changed from

==========
color: Remove calls that break color correct rendering layout tests

Elimintate default use of the "generic RGB" color profile when color
correct rendering is enabled.

Explicitly break the Javascript setColorSpace API. These functions did
nothing with color correct rendering disabled (they raced with something
that always beat it), and they create races with color correct rendering
enabled.

The purpose of the above is to test different output color spaces, which
we will be doing through virtual test suites, which will remove the
platform dependency and not be racy.

BUG=713891
==========

to

==========
color: Disable Javascript setColorSpace with color correct rendering

Explicitly disable the Javascript setColorSpace API when color correct
rendering is enabled. These functions do (almost) nothing when color
correct rendering is disabled (they raced with something that always
beat it), and they create races with color correct rendering enabled.

The purpose of the JS API is to test different output color spaces, which
we will be doing through virtual test suites, which will remove the
platform dependency and not be racy.

TBR=avi@ (for OWNERS)
BUG=713891
==========

[ccameron, 2017-06-04 17:11:54]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2017-06-04 17:21:16]

Description was changed from

==========
color: Disable Javascript setColorSpace with color correct rendering

Explicitly disable the Javascript setColorSpace API when color correct
rendering is enabled. These functions do (almost) nothing when color
correct rendering is disabled (they raced with something that always
beat it), and they create races with color correct rendering enabled.

The purpose of the JS API is to test different output color spaces, which
we will be doing through virtual test suites, which will remove the
platform dependency and not be racy.

TBR=avi@ (for OWNERS)
BUG=713891
==========

to

==========
color: Disable Javascript setColorSpace with color correct rendering

Explicitly disable the Javascript setColorSpace API when color correct
rendering is enabled. These functions do (almost) nothing when color
correct rendering is disabled (they raced with something that always
beat it), and they create races with color correct rendering enabled.

The purpose of the JS API is to test different output color spaces, which
we will be doing through virtual test suites, which will remove the
platform dependency and not be racy.

TBR=avi (for OWNERS)
TBR=enne (for the plan)
BUG=713891
==========

[ccameron, 2017-06-04 17:21:50]

Description was changed from

==========
color: Disable Javascript setColorSpace with color correct rendering

Explicitly disable the Javascript setColorSpace API when color correct
rendering is enabled. These functions do (almost) nothing when color
correct rendering is disabled (they raced with something that always
beat it), and they create races with color correct rendering enabled.

The purpose of the JS API is to test different output color spaces, which
we will be doing through virtual test suites, which will remove the
platform dependency and not be racy.

TBR=avi (for OWNERS)
TBR=enne (for the plan)
BUG=713891
==========

to

==========
color: Disable Javascript setColorSpace with color correct rendering

Explicitly disable the Javascript setColorSpace API when color correct
rendering is enabled. These functions do (almost) nothing when color
correct rendering is disabled (they raced with something that always
beat it), and they create races with color correct rendering enabled.

The purpose of the JS API is to test different output color spaces, which
we will be doing through virtual test suites, which will remove the
platform dependency and not be racy.

Also don't give Mac a different default color space when using color
correct rendering -- use sRGB across the board.

TBR=avi (for OWNERS)
TBR=enne (for the plan)
BUG=713891
==========

[ccameron, 2017-06-04 17:24:30]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-06-04 17:24:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-04 18:35:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496597070751130,
"parent_rev": "5a1bfce474e0906a08ea8cfede4e4ed552770db9", "commit_rev":
"772317d1eec55c7ef441a39a7349856a3d01ed65"}

[commit-bot: I haz the power, 2017-06-04 18:35:15]

Description was changed from

==========
color: Disable Javascript setColorSpace with color correct rendering

Explicitly disable the Javascript setColorSpace API when color correct
rendering is enabled. These functions do (almost) nothing when color
correct rendering is disabled (they raced with something that always
beat it), and they create races with color correct rendering enabled.

The purpose of the JS API is to test different output color spaces, which
we will be doing through virtual test suites, which will remove the
platform dependency and not be racy.

Also don't give Mac a different default color space when using color
correct rendering -- use sRGB across the board.

TBR=avi (for OWNERS)
TBR=enne (for the plan)
BUG=713891
==========

to

==========
color: Disable Javascript setColorSpace with color correct rendering

Explicitly disable the Javascript setColorSpace API when color correct
rendering is enabled. These functions do (almost) nothing when color
correct rendering is disabled (they raced with something that always
beat it), and they create races with color correct rendering enabled.

The purpose of the JS API is to test different output color spaces, which
we will be doing through virtual test suites, which will remove the
platform dependency and not be racy.

Also don't give Mac a different default color space when using color
correct rendering -- use sRGB across the board.

TBR=avi (for OWNERS)
TBR=enne (for the plan)
BUG=713891

Review-Url: https://codereview.chromium.org/2925473002
Cr-Commit-Position: refs/heads/master@{#476911}
Committed:
https://chromium.googlesource.com/chromium/src/+/772317d1eec55c7ef441a39a7349...
==========

[commit-bot: I haz the power, 2017-06-04 18:35:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/772317d1eec55c7ef441a39a7349...