color: Enable color correct rendering for images/ layout tests

color: Enable color correct rendering for images/ layout tests

Do this for both software rasterization only for now.

Force all platforms to use sRGB as their color space. A separate virtual
test suite will be added to test more exotic color spaces.

BUG=713891
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2916713002
Cr-Commit-Position: refs/heads/master@{#477096}
Committed: https://chromium.googlesource.com/chromium/src/+/200555e667f964ed2f057660039c072278d170ad

[ccameron, 2017-05-31 21:33:51]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org, qyearsley@chromium.org

[ccameron, 2017-05-31 21:33:52]

ptal -- I'll be pulling a bunch of rebaselines into this as soon as
https://skia-review.googlesource.com/c/18282/ rolls in.

[qyearsley, 2017-05-31 21:42:32]

On 2017/05/31 at 21:33:52, ccameron wrote:
> ptal -- I'll be pulling a bunch of rebaselines into this as soon as
https://skia-review.googlesource.com/c/18282/ rolls in.

Excellent, LGTM; I guess we can try to use try jobs and "webkit-patch
rebaseline-cl" to get the baselines, right?

[enne (OOO), 2017-05-31 21:44:29]

Trying to differentiate between whether this should be a virtual test suite or a
physical one, I'm assuming that color correct rendering is eventually going to
be the default and the physical test suite can go away because it's on by
default?

[ccameron, 2017-05-31 23:14:26]

On 2017/05/31 21:44:29, enne wrote:
> Trying to differentiate between whether this should be a virtual test suite or
a
> physical one, I'm assuming that color correct rendering is eventually going to
> be the default and the physical test suite can go away because it's on by
> default?

Yes, exactly -- the physical test suite will go away once all tests are moved to
color correct rendering.

[enne (OOO), 2017-06-01 15:07:53]

lgtm

[ccameron, 2017-06-04 23:03:08]

Patchset #2 (id:20001) has been deleted

[ccameron, 2017-06-04 23:03:21]

Patchset #2 (id:40001) has been deleted

[ccameron, 2017-06-04 23:03:30]

Patchset #2 (id:60001) has been deleted

[ccameron, 2017-06-04 23:03:35]

Patchset #2 (id:80001) has been deleted

[ccameron, 2017-06-04 23:03:42]

Patchset #2 (id:100001) has been deleted

[ccameron, 2017-06-04 23:03:55]

Patchset #2 (id:120001) has been deleted

[ccameron, 2017-06-04 23:04:07]

Patchset #2 (id:140001) has been deleted

[ccameron, 2017-06-04 23:04:15]

Patchset #2 (id:160001) has been deleted

[ccameron, 2017-06-04 23:04:23]

Patchset #2 (id:180001) has been deleted

[ccameron, 2017-06-04 23:04:33]

Patchset #2 (id:200001) has been deleted

[ccameron, 2017-06-05 20:24:25]

Description was changed from

==========
color: Enable color correct rendering for images/ layout tests

Do this for both the virtual test suite and the physical test suite.

Force all platforms to use sRGB as their color space. A separate virtual
test suite will be added to test more exotic color spaces.

BUG=713891
==========

to

==========
color: Enable color correct rendering for images/ layout tests

Do this for both software rasterization only for now.

Force all platforms to use sRGB as their color space. A separate virtual
test suite will be added to test more exotic color spaces.

BUG=713891
==========

[ccameron, 2017-06-05 20:37:04]

Description was changed from

==========
color: Enable color correct rendering for images/ layout tests

Do this for both software rasterization only for now.

Force all platforms to use sRGB as their color space. A separate virtual
test suite will be added to test more exotic color spaces.

BUG=713891
==========

to

==========
color: Enable color correct rendering for images/ layout tests

Do this for both software rasterization only for now.

Force all platforms to use sRGB as their color space. A separate virtual
test suite will be added to test more exotic color spaces.

BUG=713891
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-06-05 20:42:41]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-06-05 20:42:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2916713002/#ps280001
(title: "Don't pull in extra patch by accident this time ...")

[commit-bot: I haz the power, 2017-06-05 20:43:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 22:12:00]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1496695361807570,
"parent_rev": "9acd0160c7449a806fa3a51bed5d2fb7aa9b350f", "commit_rev":
"200555e667f964ed2f057660039c072278d170ad"}

[commit-bot: I haz the power, 2017-06-05 22:12:10]

Description was changed from

==========
color: Enable color correct rendering for images/ layout tests

Do this for both software rasterization only for now.

Force all platforms to use sRGB as their color space. A separate virtual
test suite will be added to test more exotic color spaces.

BUG=713891
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
color: Enable color correct rendering for images/ layout tests

Do this for both software rasterization only for now.

Force all platforms to use sRGB as their color space. A separate virtual
test suite will be added to test more exotic color spaces.

BUG=713891
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2916713002
Cr-Commit-Position: refs/heads/master@{#477096}
Committed:
https://chromium.googlesource.com/chromium/src/+/200555e667f964ed2f057660039c...
==========

[commit-bot: I haz the power, 2017-06-05 22:12:12]

Committed patchset #5 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/200555e667f964ed2f057660039c...