Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2925333002: Revert of [heap] Use larger marking steps during external allocation pressure (Closed)

Created:
3 years, 6 months ago by Michael Achenbach
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Use larger marking steps during external allocation pressure (patchset #4 id:60001 of https://codereview.chromium.org/2927553003/ ) Reason for revert: Blocks the roll. Fails some layout tests: https://build.chromium.org/p/tryserver.v8/builders/v8_linux_blink_rel/builds/21757 STDERR: # Fatal error in ../../v8/src/heap/heap.cc, line 957 STDERR: # Check failed: 1.0 <= pressure (1 vs. -0.00503761). Original issue's description: > [heap] Use larger marking steps during external allocation pressure > > BUG=chromium:626082, chromium:728228 > > Review-Url: https://codereview.chromium.org/2927553003 > Cr-Commit-Position: refs/heads/master@{#45784} > Committed: https://chromium.googlesource.com/v8/v8/+/8d75644fc0ce1cee5d6eca42006f4c4aa89e9b86 TBR=ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:626082, chromium:728228 Review-Url: https://codereview.chromium.org/2925333002 Cr-Commit-Position: refs/heads/master@{#45797} Committed: https://chromium.googlesource.com/v8/v8/+/195eab4619ace704d34ebd00b197ff8d7c739df7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/heap/heap.cc View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [heap] Use larger marking steps during external allocation pressure
3 years, 6 months ago (2017-06-08 21:19:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925333002/1
3 years, 6 months ago (2017-06-08 21:19:40 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 21:19:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/195eab4619ace704d34ebd00b197ff8d7c7...

Powered by Google App Engine
This is Rietveld 408576698