[heap] Use larger marking steps during external allocation pressure

[heap] Use larger marking steps during external allocation pressure

BUG=chromium:626082, chromium:728228
Review-Url: https://codereview.chromium.org/2927553003
Cr-Commit-Position: refs/heads/master@{#45784}
Committed: https://chromium.googlesource.com/v8/v8/+/8d75644fc0ce1cee5d6eca42006f4c4aa89e9b86

[Hannes Payer (out of office), 2017-06-06 14:09:25]

Description was changed from

==========
[heap] Use a stricter incremental marking limit.

BUG=chromium:626082, chromium:728228
==========

to

==========
[heap] Use a stricter external incremental marking limit.

BUG=chromium:626082, chromium:728228
==========

[Hannes Payer (out of office), 2017-06-06 14:09:25]

hpayer@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2017-06-06 14:14:52]

https://codereview.chromium.org/2927553003/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2927553003/diff/1/src/heap/heap.cc#newcode933
src/heap/heap.cc:933: if (external_memory_ > (external_memory_limit_ +
kExternalMemoryHardLimit)) {
128MB increase of external memory will trigger non-incremental GC? If so, seems
too aggressive.

[Hannes Payer (out of office), 2017-06-06 16:21:47]

Description was changed from

==========
[heap] Use a stricter external incremental marking limit.

BUG=chromium:626082, chromium:728228
==========

to

==========
[heap] Use larger marking steps during external allocation pressure

BUG=chromium:626082, chromium:728228
==========

[ulan, 2017-06-06 16:27:50]

ps2 lgtm

[Hannes Payer (out of office), 2017-06-06 18:39:26]

The CQ bit was checked by hpayer@chromium.org

[commit-bot: I haz the power, 2017-06-06 18:39:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 18:59:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 18:59:25]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Hannes Payer (out of office), 2017-06-07 11:41:58]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 11:42:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 12:00:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 12:00:37]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Hannes Payer (out of office), 2017-06-07 12:24:03]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 12:24:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 12:50:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 12:50:08]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2017-06-08 08:56:27]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-06-08 08:56:28]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2927553003/#ps60001
(title: "check")

[commit-bot: I haz the power, 2017-06-08 08:56:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 08:58:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496912187580190,
"parent_rev": "aed96e7b049ca41108bc9d69aad5e764a66ee9f3", "commit_rev":
"8d75644fc0ce1cee5d6eca42006f4c4aa89e9b86"}

[commit-bot: I haz the power, 2017-06-08 08:58:34]

Description was changed from

==========
[heap] Use larger marking steps during external allocation pressure

BUG=chromium:626082, chromium:728228
==========

to

==========
[heap] Use larger marking steps during external allocation pressure

BUG=chromium:626082, chromium:728228

Review-Url: https://codereview.chromium.org/2927553003
Cr-Commit-Position: refs/heads/master@{#45784}
Committed:
https://chromium.googlesource.com/v8/v8/+/8d75644fc0ce1cee5d6eca42006f4c4aa89...
==========

[commit-bot: I haz the power, 2017-06-08 08:58:36]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/8d75644fc0ce1cee5d6eca42006f4c4aa89...

[Michael Achenbach, 2017-06-08 21:19:35]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2925333002/ by machenbach@chromium.org.

The reason for reverting is: Blocks the roll. Fails some layout tests:
https://build.chromium.org/p/tryserver.v8/builders/v8_linux_blink_rel/builds/...

STDERR: # Fatal error in ../../v8/src/heap/heap.cc, line 957
STDERR: # Check failed: 1.0 <= pressure (1 vs. -0.00503761)..