Make SpdySessionKey a const member of HttpStreamFactoryImpl::Job

Make SpdySessionKey a const member of HttpStreamFactoryImpl::Job

SpdySessionKey creation depends on proxy resolution result. Since proxy
resolution is now done before Job is created, this allows us to make
SpdySessionKey a const member of HttpStreamFactoryImpl::Job.

BUG=475060, 706974, 718576
Review-Url: https://codereview.chromium.org/2925093002
Cr-Commit-Position: refs/heads/master@{#477674}
Committed: https://chromium.googlesource.com/chromium/src/+/253a62d89689b5a61846a38d48037d0ea719f905

[xunjieli, 2017-06-07 14:20:01]

xunjieli@chromium.org changed reviewers:
+ bnc@chromium.org

[xunjieli, 2017-06-07 14:20:01]

Bence, PTAL. Thanks.

[xunjieli, 2017-06-07 14:20:07]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 14:20:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-06-07 14:53:33]

LGTM with nit, also please refer to https://crbug.com/706974 and
https://crbug.com/475060 in CL description, like this:
BUG=475060, 706974, 718576

https://codereview.chromium.org/2925093002/diff/1/net/http/http_stream_factor...
File net/http/http_stream_factory_impl_job.h (right):

https://codereview.chromium.org/2925093002/diff/1/net/http/http_stream_factor...
net/http/http_stream_factory_impl_job.h:351: SpdySessionKey GetSpdySessionKey()
const;
Nit: please update HttpStreamFactoryImplJobPeer::GetSpdySessionKey()
implementation accordingly.

[xunjieli, 2017-06-07 15:03:31]

Description was changed from

==========
Make SpdySessionKey a const member of HttpStreamFactoryImpl::Job

SpdySessionKey creation depends on proxy resolution result. Since proxy
resolution is now done before Job is created, this allows us to make
SpdySessionKey a const member of HttpStreamFactoryImpl::Job.

BUG=718576
==========

to

==========
Make SpdySessionKey a const member of HttpStreamFactoryImpl::Job

SpdySessionKey creation depends on proxy resolution result. Since proxy
resolution is now done before Job is created, this allows us to make
SpdySessionKey a const member of HttpStreamFactoryImpl::Job.

BUG=475060, 706974, 718576
==========

[xunjieli, 2017-06-07 15:04:18]

Done. Thanks!

https://codereview.chromium.org/2925093002/diff/1/net/http/http_stream_factor...
File net/http/http_stream_factory_impl_job.h (right):

https://codereview.chromium.org/2925093002/diff/1/net/http/http_stream_factor...
net/http/http_stream_factory_impl_job.h:351: SpdySessionKey GetSpdySessionKey()
const;
On 2017/06/07 14:53:33, Bence wrote:
> Nit: please update HttpStreamFactoryImplJobPeer::GetSpdySessionKey()
> implementation accordingly.

Done.

[xunjieli, 2017-06-07 15:04:26]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 15:04:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-06-07 15:05:20]

On 2017/06/07 15:04:18, xunjieli wrote:
> Done. Thanks!
> 
>
https://codereview.chromium.org/2925093002/diff/1/net/http/http_stream_factor...
> File net/http/http_stream_factory_impl_job.h (right):
> 
>
https://codereview.chromium.org/2925093002/diff/1/net/http/http_stream_factor...
> net/http/http_stream_factory_impl_job.h:351: SpdySessionKey
GetSpdySessionKey()
> const;
> On 2017/06/07 14:53:33, Bence wrote:
> > Nit: please update HttpStreamFactoryImplJobPeer::GetSpdySessionKey()
> > implementation accordingly.
> 
> Done.

LGTM, thank you!

[xunjieli, 2017-06-07 15:14:56]

The CQ bit was unchecked by xunjieli@chromium.org

[xunjieli, 2017-06-07 15:14:59]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2017-06-07 15:15:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 16:25:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496848499776410,
"parent_rev": "9f6c7fe99a9bd92bce38ebc9c629c89ccacd07eb", "commit_rev":
"253a62d89689b5a61846a38d48037d0ea719f905"}

[commit-bot: I haz the power, 2017-06-07 16:25:33]

Description was changed from

==========
Make SpdySessionKey a const member of HttpStreamFactoryImpl::Job

SpdySessionKey creation depends on proxy resolution result. Since proxy
resolution is now done before Job is created, this allows us to make
SpdySessionKey a const member of HttpStreamFactoryImpl::Job.

BUG=475060, 706974, 718576
==========

to

==========
Make SpdySessionKey a const member of HttpStreamFactoryImpl::Job

SpdySessionKey creation depends on proxy resolution result. Since proxy
resolution is now done before Job is created, this allows us to make
SpdySessionKey a const member of HttpStreamFactoryImpl::Job.

BUG=475060, 706974, 718576

Review-Url: https://codereview.chromium.org/2925093002
Cr-Commit-Position: refs/heads/master@{#477674}
Committed:
https://chromium.googlesource.com/chromium/src/+/253a62d89689b5a61846a38d4803...
==========

[commit-bot: I haz the power, 2017-06-07 16:25:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/253a62d89689b5a61846a38d4803...