Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2925093002: Make SpdySessionKey a const member of HttpStreamFactoryImpl::Job (Closed)

Created:
3 years, 6 months ago by xunjieli
Modified:
3 years, 6 months ago
Reviewers:
Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, Ryan Hamilton
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SpdySessionKey a const member of HttpStreamFactoryImpl::Job SpdySessionKey creation depends on proxy resolution result. Since proxy resolution is now done before Job is created, this allows us to make SpdySessionKey a const member of HttpStreamFactoryImpl::Job. BUG=475060, 706974, 718576 Review-Url: https://codereview.chromium.org/2925093002 Cr-Commit-Position: refs/heads/master@{#477674} Committed: https://chromium.googlesource.com/chromium/src/+/253a62d89689b5a61846a38d48037d0ea719f905

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -37 lines) Patch
M net/http/http_stream_factory_impl_job.h View 3 chunks +5 lines, -4 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 11 chunks +14 lines, -32 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
xunjieli
Bence, PTAL. Thanks.
3 years, 6 months ago (2017-06-07 14:20:01 UTC) #2
Bence
LGTM with nit, also please refer to https://crbug.com/706974 and https://crbug.com/475060 in CL description, like this: ...
3 years, 6 months ago (2017-06-07 14:53:33 UTC) #5
xunjieli
Done. Thanks! https://codereview.chromium.org/2925093002/diff/1/net/http/http_stream_factory_impl_job.h File net/http/http_stream_factory_impl_job.h (right): https://codereview.chromium.org/2925093002/diff/1/net/http/http_stream_factory_impl_job.h#newcode351 net/http/http_stream_factory_impl_job.h:351: SpdySessionKey GetSpdySessionKey() const; On 2017/06/07 14:53:33, Bence ...
3 years, 6 months ago (2017-06-07 15:04:18 UTC) #7
Bence
On 2017/06/07 15:04:18, xunjieli wrote: > Done. Thanks! > > https://codereview.chromium.org/2925093002/diff/1/net/http/http_stream_factory_impl_job.h > File net/http/http_stream_factory_impl_job.h (right): ...
3 years, 6 months ago (2017-06-07 15:05:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925093002/20001
3 years, 6 months ago (2017-06-07 15:15:07 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 16:25:34 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/253a62d89689b5a61846a38d4803...

Powered by Google App Engine
This is Rietveld 408576698