Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: net/http/http_stream_factory_impl_job.h

Issue 2925093002: Make SpdySessionKey a const member of HttpStreamFactoryImpl::Job (Closed)
Patch Set: address comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_stream_factory_impl_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_job.h
diff --git a/net/http/http_stream_factory_impl_job.h b/net/http/http_stream_factory_impl_job.h
index 11361536f1881623bf027d8ad81f0b60f2d26b10..6173224eb822c7cd1fe16c0de35f1292332f8713 100644
--- a/net/http/http_stream_factory_impl_job.h
+++ b/net/http/http_stream_factory_impl_job.h
@@ -334,8 +334,6 @@ class HttpStreamFactoryImpl::Job {
// Set the motivation for this request onto the underlying socket.
void SetSocketMotivation();
- bool IsHttpsProxyAndHttpUrl() const;
-
// Is this a SPDY or QUIC alternative Job?
bool IsSpdyAlternative() const;
bool IsQuicAlternative() const;
@@ -349,6 +347,7 @@ class HttpStreamFactoryImpl::Job {
// After calling, the caller can use ssl_info_.
void GetSSLInfo();
+ // Called in Job constructor. Use |spdy_session_key_| after construction.
SpdySessionKey GetSpdySessionKey() const;
// Returns true if the current request can use an existing spdy session.
@@ -473,8 +472,10 @@ class HttpStreamFactoryImpl::Job {
// Initialized when we have an existing SpdySession.
base::WeakPtr<SpdySession> existing_spdy_session_;
- // Only used if |new_spdy_session_| is non-NULL.
- bool spdy_session_direct_;
+ // True if not connecting to an Https proxy for an Http url.
+ const bool spdy_session_direct_;
+
+ const SpdySessionKey spdy_session_key_;
base::TimeTicks job_stream_ready_start_time_;
« no previous file with comments | « no previous file | net/http/http_stream_factory_impl_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698