Revert of [Payment Request] Moves PaymentRequestViewController to :payments_ui

Revert of [Payment Request] Moves PaymentRequestViewController to :payments_ui (patchset #2 id:20001 of https://codereview.chromium.org/2924663003/ )

Reason for revert:
I'm not really sure why the CQ let this patch land but it's blocking (entirely unrelated) commits, see below:


""" to /b/build/slave/ios-device/build/src/out/Release-iphoneos/args.gn.
/b/build/slave/ios-device/build/src/buildtools/mac/gn gen //out/Release-iphoneos --check
  -> returned 1
ERROR at //ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm:17:11: Can't include this header from here.
#include "components/signin/core/browser/signin_manager.h"
          ^----------------------------------------------
The target:
  //ios/chrome/browser/ui/payments:unit_tests
is including a file from the target:
  //components/signin/core/browser:browser
It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.
Dependency chain (there may also be others):
  //ios/chrome/browser/ui/payments:unit_tests -->
  //ios/chrome/browser/ui/payments:payments --[private]-->
  //components/signin/core/browser:browser

E.g. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fios-device%2F226891%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files__mb___with_patch_%2F0%2Fstdout
___________________

Original issue's description:
> [Payment Request] Moves PaymentRequestViewController to :payments_ui
> 
> * Moves PaymentRequestViewControllerDataSource to its own file.
> * Moves chrome related logic (creation of the model items) to mediator.
> * Moves the PaymentRequestViewController to the :payments_ui target.
> * Adds unit tests for the view controller and the mediator.
> * Adds methods needed by the tests to the TestPaymentRequest.
> 
> BUG=602666
> 
> Review-Url: https://codereview.chromium.org/2924663003
> Cr-Commit-Position: refs/heads/master@{#477517}
> Committed: https://chromium.googlesource.com/chromium/src/+/7de77b49cab72134899a55afd0dde19cefbd8af8

TBR=lpromero@chromium.org,mahmadi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602666
Review-Url: https://codereview.chromium.org/2925053002
Cr-Commit-Position: refs/heads/master@{#477585}
Committed: https://chromium.googlesource.com/chromium/src/+/cef722cc47710f102fcbccdb79cde49a9087b05e

[alex clarke (OOO till 29th), 2017-06-07 08:59:58]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2017-06-07 08:59:59]

Created Revert of [Payment Request] Moves PaymentRequestViewController to
:payments_ui

[commit-bot: I haz the power, 2017-06-07 09:00:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 09:00:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496825998773590, "parent_rev":
"6bf8ffab8059f83d6fd93485184627fbe3fce2e2", "commit_rev":
"cef722cc47710f102fcbccdb79cde49a9087b05e"}

[commit-bot: I haz the power, 2017-06-07 09:00:40]

Description was changed from

==========
Revert of [Payment Request] Moves PaymentRequestViewController to :payments_ui
(patchset #2 id:20001 of https://codereview.chromium.org/2924663003/ )

Reason for revert:
I'm not really sure why the CQ let this patch land but it's blocking (entirely
unrelated) commits, see below:


""" to /b/build/slave/ios-device/build/src/out/Release-iphoneos/args.gn.
/b/build/slave/ios-device/build/src/buildtools/mac/gn gen //out/Release-iphoneos
--check
  -> returned 1
ERROR at
//ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm:17:11:
Can't include this header from here.
#include "components/signin/core/browser/signin_manager.h"
          ^----------------------------------------------
The target:
  //ios/chrome/browser/ui/payments:unit_tests
is including a file from the target:
  //components/signin/core/browser:browser
It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.
Dependency chain (there may also be others):
  //ios/chrome/browser/ui/payments:unit_tests -->
  //ios/chrome/browser/ui/payments:payments --[private]-->
  //components/signin/core/browser:browser

E.g.
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
___________________

Original issue's description:
> [Payment Request] Moves PaymentRequestViewController to :payments_ui
> 
> * Moves PaymentRequestViewControllerDataSource to its own file.
> * Moves chrome related logic (creation of the model items) to mediator.
> * Moves the PaymentRequestViewController to the :payments_ui target.
> * Adds unit tests for the view controller and the mediator.
> * Adds methods needed by the tests to the TestPaymentRequest.
> 
> BUG=602666
> 
> Review-Url: https://codereview.chromium.org/2924663003
> Cr-Commit-Position: refs/heads/master@{#477517}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7de77b49cab72134899a55afd0dd...

TBR=lpromero@chromium.org,mahmadi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602666
==========

to

==========
Revert of [Payment Request] Moves PaymentRequestViewController to :payments_ui
(patchset #2 id:20001 of https://codereview.chromium.org/2924663003/ )

Reason for revert:
I'm not really sure why the CQ let this patch land but it's blocking (entirely
unrelated) commits, see below:


""" to /b/build/slave/ios-device/build/src/out/Release-iphoneos/args.gn.
/b/build/slave/ios-device/build/src/buildtools/mac/gn gen //out/Release-iphoneos
--check
  -> returned 1
ERROR at
//ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm:17:11:
Can't include this header from here.
#include "components/signin/core/browser/signin_manager.h"
          ^----------------------------------------------
The target:
  //ios/chrome/browser/ui/payments:unit_tests
is including a file from the target:
  //components/signin/core/browser:browser
It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.
Dependency chain (there may also be others):
  //ios/chrome/browser/ui/payments:unit_tests -->
  //ios/chrome/browser/ui/payments:payments --[private]-->
  //components/signin/core/browser:browser

E.g.
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
___________________

Original issue's description:
> [Payment Request] Moves PaymentRequestViewController to :payments_ui
> 
> * Moves PaymentRequestViewControllerDataSource to its own file.
> * Moves chrome related logic (creation of the model items) to mediator.
> * Moves the PaymentRequestViewController to the :payments_ui target.
> * Adds unit tests for the view controller and the mediator.
> * Adds methods needed by the tests to the TestPaymentRequest.
> 
> BUG=602666
> 
> Review-Url: https://codereview.chromium.org/2924663003
> Cr-Commit-Position: refs/heads/master@{#477517}
> Committed:
https://chromium.googlesource.com/chromium/src/+/7de77b49cab72134899a55afd0dd...

TBR=lpromero@chromium.org,mahmadi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602666

Review-Url: https://codereview.chromium.org/2925053002
Cr-Commit-Position: refs/heads/master@{#477585}
Committed:
https://chromium.googlesource.com/chromium/src/+/cef722cc47710f102fcbccdb79cd...
==========

[commit-bot: I haz the power, 2017-06-07 09:00:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cef722cc47710f102fcbccdb79cd...

[lpromero, 2017-06-07 09:23:03]

On 2017/06/07 09:00:41, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/cef722cc47710f102fcbccdb79cd...

lgtm

https://chromium-review.googlesource.com/c/527072/ was supposed to fix it.