[Payment Request] Moves PaymentRequestViewController to :payments_ui

[Payment Request] Moves PaymentRequestViewController to :payments_ui

* Moves PaymentRequestViewControllerDataSource to its own file.
* Moves chrome related logic (creation of the model items) to mediator.
* Moves the PaymentRequestViewController to the :payments_ui target.
* Adds unit tests for the view controller and the mediator.
* Adds methods needed by the tests to the TestPaymentRequest.

BUG=602666
Review-Url: https://codereview.chromium.org/2924663003
Cr-Original-Commit-Position: refs/heads/master@{#477517}
Committed: https://chromium.googlesource.com/chromium/src/+/7de77b49cab72134899a55afd0dde19cefbd8af8
Review-Url: https://codereview.chromium.org/2924663003
Cr-Commit-Position: refs/heads/master@{#477630}
Committed: https://chromium.googlesource.com/chromium/src/+/59c412850478a9e516564aa0a6976d187e59ec57

[Moe, 2017-06-05 21:28:04]

mahmadi@chromium.org changed reviewers:
+ lpromero@chromium.org

[Moe, 2017-06-05 21:28:04]

Hi Louis, Please take a look. This is the last view controller to move to the
:payments_ui
Sorry for the large CL!! Please let me know if you want me to move the unit
tests to a separate one.

[lpromero, 2017-06-06 09:43:55]

LGTM. Thank you!

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/test_payment_request.h (right):

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/test_payment_request.h:45: // Removes all the creidt
cards.
*credit

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm
(right):

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm:74: 
Is there a reason for this new line? (For example, does it mean that this data
member must come before the ones below?)

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm:83: // Tests
wether payment can be completed when expected.
*whether

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/ui/payme...
File
ios/chrome/browser/ui/payments/payment_request_view_controller_data_source.h
(right):

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/payment_request_view_controller_data_source.h:59:
// Returns the item displayed at the botton of the view.
*bottom

[Moe, 2017-06-06 20:10:24]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 20:10:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 21:42:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 21:42:55]

Dry run: This issue passed the CQ dry run.

[Moe, 2017-06-07 02:12:40]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-06-07 02:12:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2924663003/#ps20001
(title: "Addressed comments")

[Moe, 2017-06-07 02:12:51]

Thank you Louis!

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/test_payment_request.h (right):

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/test_payment_request.h:45: // Removes all the creidt
cards.
On 2017/06/06 at 09:43:54, lpromero wrote:
> *credit

Done.

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm
(right):

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm:74: 
On 2017/06/06 at 09:43:55, lpromero wrote:
> Is there a reason for this new line? (For example, does it mean that this data
member must come before the ones below?)

Exactly. Here,
https://cs.chromium.org/chromium/src/ios/web/public/test/test_web_thread_bund...,
it says: "It is a good idea to put the TestWebThreadBundle as the first member
variable in test classes, so it is destroyed last..."

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm:83: // Tests
wether payment can be completed when expected.
On 2017/06/06 at 09:43:55, lpromero wrote:
> *whether

Done.

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/ui/payme...
File
ios/chrome/browser/ui/payments/payment_request_view_controller_data_source.h
(right):

https://codereview.chromium.org/2924663003/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/payment_request_view_controller_data_source.h:59:
// Returns the item displayed at the botton of the view.
On 2017/06/06 at 09:43:55, lpromero wrote:
> *bottom

Done.

[commit-bot: I haz the power, 2017-06-07 02:12:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 02:17:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496801560004330,
"parent_rev": "0c615326f02461f8de0b5ed97af7384e78902e36", "commit_rev":
"7de77b49cab72134899a55afd0dde19cefbd8af8"}

[commit-bot: I haz the power, 2017-06-07 02:17:46]

Description was changed from

==========
[Payment Request] Moves PaymentRequestViewController to :payments_ui

* Moves PaymentRequestViewControllerDataSource to its own file.
* Moves chrome related logic (creation of the model items) to mediator.
* Moves the PaymentRequestViewController to the :payments_ui target.
* Adds unit tests for the view controller and the mediator.
* Adds methods needed by the tests to the TestPaymentRequest.

BUG=602666
==========

to

==========
[Payment Request] Moves PaymentRequestViewController to :payments_ui

* Moves PaymentRequestViewControllerDataSource to its own file.
* Moves chrome related logic (creation of the model items) to mediator.
* Moves the PaymentRequestViewController to the :payments_ui target.
* Adds unit tests for the view controller and the mediator.
* Adds methods needed by the tests to the TestPaymentRequest.

BUG=602666

Review-Url: https://codereview.chromium.org/2924663003
Cr-Commit-Position: refs/heads/master@{#477517}
Committed:
https://chromium.googlesource.com/chromium/src/+/7de77b49cab72134899a55afd0dd...
==========

[commit-bot: I haz the power, 2017-06-07 02:17:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7de77b49cab72134899a55afd0dd...

[alex clarke (OOO till 29th), 2017-06-07 08:59:58]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2925053002/ by alexclarke@chromium.org.

The reason for reverting is: I'm not really sure why the CQ let this patch land
but it's blocking (entirely unrelated) commits, see below:


""" to /b/build/slave/ios-device/build/src/out/Release-iphoneos/args.gn.
/b/build/slave/ios-device/build/src/buildtools/mac/gn gen //out/Release-iphoneos
--check
  -> returned 1
ERROR at
//ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm:17:11:
Can't include this header from here.
#include "components/signin/core/browser/signin_manager.h"
          ^----------------------------------------------
The target:
  //ios/chrome/browser/ui/payments:unit_tests
is including a file from the target:
  //components/signin/core/browser:browser
It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.
Dependency chain (there may also be others):
  //ios/chrome/browser/ui/payments:unit_tests -->
  //ios/chrome/browser/ui/payments:payments --[private]-->
  //components/signin/core/browser:browser

E.g.
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
___________________.

[gambard, 2017-06-07 10:35:39]

gambard@chromium.org changed reviewers:
+ gambard@chromium.org

[gambard, 2017-06-07 10:35:40]

I have landed https://chromium-review.googlesource.com/c/527072 which should fix
it. You should be able to reland this CL as it is.

[Moe, 2017-06-07 14:07:53]

On 2017/06/07 at 10:35:40, gambard wrote:
> I have landed https://chromium-review.googlesource.com/c/527072 which should
fix it. You should be able to reland this CL as it is.

Thank you Gauthier! Have no idea why try bots didn't catch this.

[Moe, 2017-06-07 14:12:02]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2017-06-07 14:12:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 14:16:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496844722967170,
"parent_rev": "c2c533485e6c87a3779b9db12e8c3c864330192a", "commit_rev":
"59c412850478a9e516564aa0a6976d187e59ec57"}

[commit-bot: I haz the power, 2017-06-07 14:17:05]

Description was changed from

==========
[Payment Request] Moves PaymentRequestViewController to :payments_ui

* Moves PaymentRequestViewControllerDataSource to its own file.
* Moves chrome related logic (creation of the model items) to mediator.
* Moves the PaymentRequestViewController to the :payments_ui target.
* Adds unit tests for the view controller and the mediator.
* Adds methods needed by the tests to the TestPaymentRequest.

BUG=602666

Review-Url: https://codereview.chromium.org/2924663003
Cr-Commit-Position: refs/heads/master@{#477517}
Committed:
https://chromium.googlesource.com/chromium/src/+/7de77b49cab72134899a55afd0dd...
==========

to

==========
[Payment Request] Moves PaymentRequestViewController to :payments_ui

* Moves PaymentRequestViewControllerDataSource to its own file.
* Moves chrome related logic (creation of the model items) to mediator.
* Moves the PaymentRequestViewController to the :payments_ui target.
* Adds unit tests for the view controller and the mediator.
* Adds methods needed by the tests to the TestPaymentRequest.

BUG=602666

Review-Url: https://codereview.chromium.org/2924663003
Cr-Original-Commit-Position: refs/heads/master@{#477517}
Committed:
https://chromium.googlesource.com/chromium/src/+/7de77b49cab72134899a55afd0dd...
Review-Url: https://codereview.chromium.org/2924663003
Cr-Commit-Position: refs/heads/master@{#477630}
Committed:
https://chromium.googlesource.com/chromium/src/+/59c412850478a9e516564aa0a697...
==========

[commit-bot: I haz the power, 2017-06-07 14:17:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/59c412850478a9e516564aa0a697...