Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2924733002: Revert of Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec (Closed)

Created:
3 years, 6 months ago by stevenjb
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec (patchset #2 id:20001 of https://codereview.chromium.org/2920263002/ ) Reason for revert: This broke the PFQ chrome build: https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-tot-asan-informational/builds/13268 Original issue's description: > Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec > > This was split from: > https://codereview.chromium.org/2895953003/ > > BUG=724616 > > Review-Url: https://codereview.chromium.org/2920263002 > Cr-Commit-Position: refs/heads/master@{#477057} > Committed: https://chromium.googlesource.com/chromium/src/+/5f026c277b1c0945bb99b2ffcfcc76f9d10622b2 TBR=scroggo@chromium.org,dcheng@chromium.org,msarett@chromium.org,ihf@chromium.org,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=724616 Review-Url: https://codereview.chromium.org/2924733002 Cr-Commit-Position: refs/heads/master@{#477114} Committed: https://chromium.googlesource.com/chromium/src/+/84202c54588f62531bf548aecc6a313bb7a56b39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -18 lines) Patch
M ui/gfx/codec/jpeg_codec.h View 2 chunks +13 lines, -0 lines 0 comments Download
M ui/gfx/codec/jpeg_codec.cc View 14 chunks +169 lines, -5 lines 0 comments Download
M ui/gfx/codec/jpeg_codec_unittest.cc View 4 chunks +54 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
stevenjb
Created Revert of Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec
3 years, 6 months ago (2017-06-05 23:07:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924733002/1
3 years, 6 months ago (2017-06-05 23:07:56 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 23:08:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/84202c54588f62531bf548aecc6a...

Powered by Google App Engine
This is Rietveld 408576698