Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2920263002:
Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec (Closed)
DescriptionDelete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec
This was split from:
https://codereview.chromium.org/2895953003/
BUG=724616
Review-Url: https://codereview.chromium.org/2895953003/
Cr-Original-Commit-Position: refs/heads/master@{#477057}
Committed: https://chromium.googlesource.com/chromium/src/+/5f026c277b1c0945bb99b2ffcfcc76f9d10622b2
Review-Url: https://codereview.chromium.org/2920263002
Cr-Commit-Position: refs/heads/master@{#477353}
Committed: https://chromium.googlesource.com/chromium/src/+/517c65685305720413eed70a52711f3a8fe14083
Patch Set 1 #Patch Set 2 : Fix unit test #Patch Set 3 : Fix PFQ chrome build #
Messages
Total messages: 35 (25 generated)
msarett@chromium.org changed reviewers: + dcheng@chromium.org, msarett@chromium.org, scroggo@chromium.org
The CQ bit was checked by msarett@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by msarett@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by msarett@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496692521463620,
"parent_rev": "f7d9e91e64165b26cbfd95d29c33d4d6f0b46126", "commit_rev":
"5f026c277b1c0945bb99b2ffcfcc76f9d10622b2"}
Message was sent while issue was closed.
Description was changed from ========== Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec This was split from: https://codereview.chromium.org/2895953003/ BUG=724616 ========== to ========== Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec This was split from: https://codereview.chromium.org/2895953003/ BUG=724616 Review-Url: https://codereview.chromium.org/2920263002 Cr-Commit-Position: refs/heads/master@{#477057} Committed: https://chromium.googlesource.com/chromium/src/+/5f026c277b1c0945bb99b2ffcfcc... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5f026c277b1c0945bb99b2ffcfcc...
Message was sent while issue was closed.
On 2017/06/05 20:00:07, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as > https://chromium.googlesource.com/chromium/src/+/5f026c277b1c0945bb99b2ffcfcc... This appears to have broken Chrome compilation in the Chrome OS PFQ builders: https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-tot-a... chromeos-chrome-61.0.3122.0_alpha-r1: [152/15508] CXX obj/media/gpu/jpeg_decode_accelerator_unittest/jpeg_decode_accelerator_unittest.o chromeos-chrome-61.0.3122.0_alpha-r1: FAILED: obj/media/gpu/jpeg_decode_accelerator_unittest/jpeg_decode_accelerator_unittest.o chromeos-chrome-61.0.3122.0_alpha-r1: x86_64-cros-linux-gnu-clang++ -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.25.51-gold -MMD -MF obj/media/gpu/jpeg_decode_accelerator_unittest/jpeg_decode_accelerator_unittest.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DADDRESS_SANITIZER -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"303910-1\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_V4L2_CODEC -DUSE_EGL -DGTEST_API_= -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DMESA_EGL_NO_X11_HEADERS -DUNIT_TEST -I../../../../../../../home/chrome-bot/chrome_root/src -Igen -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libva -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libyuv/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebp -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos -I../../../../../../../home/chrome-bot/chrome_root/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/googletest/src/googletest/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebm/source -I../../../../../../../home/chrome-bot/chrome_root/src/skia/config -I../../../../../../../home/chrome-bot/chrome_root/src/skia/ext -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/c -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/config -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/core -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/effects -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/encode -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/images -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/lazy -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pathops -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pdf -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pipe -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/ports -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/utils -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/third_party/vulkan -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/sksl -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/common -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/i18n -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/mesa/src/include -fno-strict-aliasing -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -pthread -fcolor-diagnostics -m64 -march=x86-64 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-shift-negative-value -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g2 -gsplit-dwarf --sysroot=../../../../../../../build/amd64-generic -gline-tables-only -gcolumn-info -fno-omit-frame-pointer -fsanitize=address -fsanitize-address-use-after-scope -fsanitize-blacklist=../../../../../../../home/chrome-bot/chrome_root/src/tools/memory/asan/blacklist.txt -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -pipe -pipe -pipe -march=x86-64 -msse3 -fno-split-dwarf-inlining -D__google_stl_debug_vector=1 -Wno-unknown-warning-option -c ../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/jpeg_decode_accelerator_unittest.cc -o obj/media/gpu/jpeg_decode_accelerator_unittest/jpeg_decode_accelerator_unittest.o chromeos-chrome-61.0.3122.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/jpeg_decode_accelerator_unittest.cc:399:65: error: no member named 'FORMAT_RGB' in 'gfx::JPEGCodec'; did you mean 'FORMAT_RGBA'? chromeos-chrome-61.0.3122.0_alpha-r1: if (!gfx::JPEGCodec::Encode(&input_buffer[0], gfx::JPEGCodec::FORMAT_RGB, chromeos-chrome-61.0.3122.0_alpha-r1: ~~~~~~~~~~~~~~~~^~~~~~~~~~ chromeos-chrome-61.0.3122.0_alpha-r1: FORMAT_RGBA chromeos-chrome-61.0.3122.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ui/gfx/codec/jpeg_codec.h:27:5: note: 'FORMAT_RGBA' declared here chromeos-chrome-61.0.3122.0_alpha-r1: FORMAT_RGBA, chromeos-chrome-61.0.3122.0_alpha-r1: ^ chromeos-chrome-61.0.3122.0_alpha-r1: 1 error generated. chromeos-chrome-61.0.3122.0_alpha-r1: I'm not sure why it wasn't caught in chromeos_amd64-generic_chromium_compile_only_ng Planning to revert shortly unless I hear an objection.
Message was sent while issue was closed.
Description was changed from ========== Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec This was split from: https://codereview.chromium.org/2895953003/ BUG=724616 Review-Url: https://codereview.chromium.org/2920263002 Cr-Commit-Position: refs/heads/master@{#477057} Committed: https://chromium.googlesource.com/chromium/src/+/5f026c277b1c0945bb99b2ffcfcc... ========== to ========== Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec This was split from: https://codereview.chromium.org/2895953003/ BUG=724616 Review-Url: https://codereview.chromium.org/2920263002 Cr-Commit-Position: refs/heads/master@{#477057} Committed: https://chromium.googlesource.com/chromium/src/+/5f026c277b1c0945bb99b2ffcfcc... ==========
Message was sent while issue was closed.
stevenjb@chromium.org changed reviewers: + ihf@chromium.org
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2924733002/ by stevenjb@chromium.org. The reason for reverting is: This broke the PFQ chrome build: https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-tot-a... .
Description was changed from ========== Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec This was split from: https://codereview.chromium.org/2895953003/ BUG=724616 Review-Url: https://codereview.chromium.org/2920263002 Cr-Commit-Position: refs/heads/master@{#477057} Committed: https://chromium.googlesource.com/chromium/src/+/5f026c277b1c0945bb99b2ffcfcc... ========== to ========== Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec This was split from: https://codereview.chromium.org/2895953003/ BUG=724616 Review-Url: https://codereview.chromium.org/2895953003/ Cr-Commit-Position: refs/heads/master@{#477057} Committed: https://chromium.googlesource.com/chromium/src/+/5f026c277b1c0945bb99b2ffcfcc... ==========
Description was changed from ========== Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec This was split from: https://codereview.chromium.org/2895953003/ BUG=724616 Review-Url: https://codereview.chromium.org/2895953003/ Cr-Commit-Position: refs/heads/master@{#477057} Committed: https://chromium.googlesource.com/chromium/src/+/5f026c277b1c0945bb99b2ffcfcc... ========== to ========== Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec This was split from: https://codereview.chromium.org/2895953003/ BUG=724616 Review-Url: https://codereview.chromium.org/2895953003/ Cr-Commit-Position: refs/heads/master@{#477057} Committed: https://chromium.googlesource.com/chromium/src/+/5f026c277b1c0945bb99b2ffcfcc... CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
msarett@chromium.org changed reviewers: + sandersd@chromium.org
sandersd@, can you please take a look at media/gpu?
The CQ bit was checked by msarett@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
media/ lgtm.
The CQ bit was checked by msarett@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2920263002/#ps40001 (title: "Fix PFQ chrome build")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496774195864860,
"parent_rev": "f3ffa7cb2ab8a0a075513a328ffb4cdcee58f18c", "commit_rev":
"517c65685305720413eed70a52711f3a8fe14083"}
Message was sent while issue was closed.
Description was changed from ========== Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec This was split from: https://codereview.chromium.org/2895953003/ BUG=724616 Review-Url: https://codereview.chromium.org/2895953003/ Cr-Commit-Position: refs/heads/master@{#477057} Committed: https://chromium.googlesource.com/chromium/src/+/5f026c277b1c0945bb99b2ffcfcc... CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Delete FORMAT_RGB and legacy libjpeg support from gfx::JpegCodec This was split from: https://codereview.chromium.org/2895953003/ BUG=724616 Review-Url: https://codereview.chromium.org/2895953003/ Cr-Original-Commit-Position: refs/heads/master@{#477057} Committed: https://chromium.googlesource.com/chromium/src/+/5f026c277b1c0945bb99b2ffcfcc... Review-Url: https://codereview.chromium.org/2920263002 Cr-Commit-Position: refs/heads/master@{#477353} Committed: https://chromium.googlesource.com/chromium/src/+/517c65685305720413eed70a5271... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/517c65685305720413eed70a5271... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
