Issue 2924693002: Do not attempt to show search engine dialog if activity is dead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2924693002: Do not attempt to show search engine dialog if activity is dead. (Closed)

Created:
3 years, 6 months ago by Ted C

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

Do not attempt to show search engine dialog if activity is dead. BUG=718461 Review-Url: https://codereview.chromium.org/2911273002 Cr-Original-Commit-Position: refs/heads/master@{#475624} Review-Url: https://codereview.chromium.org/2924693002 . Cr-Commit-Position: refs/branch-heads/3112@{#168} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/21f084920b4efa522b2cb60e0f779d5cec05255c

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java	View		3 chunks	+11 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Ted C

3 years, 6 months ago (2017-06-05 20:46:51 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
21f084920b4efa522b2cb60e0f779d5cec05255c.