Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2911273002: Do not attempt to show search engine dialog if activity is dead. (Closed)

Created:
3 years, 6 months ago by Ted C
Modified:
3 years, 6 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not attempt to show search engine dialog if activity is dead. BUG=718461 Review-Url: https://codereview.chromium.org/2911273002 Cr-Commit-Position: refs/heads/master@{#475624} Committed: https://chromium.googlesource.com/chromium/src/+/bc06b2e2dbd546ff00c8d7626fb915d86136aede

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ted C
PTAL
3 years, 6 months ago (2017-05-30 16:53:32 UTC) #2
Yusuf
lgtm
3 years, 6 months ago (2017-05-30 18:13:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2911273002/1
3 years, 6 months ago (2017-05-30 18:15:05 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 19:14:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc06b2e2dbd546ff00c8d7626fb9...

Powered by Google App Engine
This is Rietveld 408576698