Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2924673004: Add UKM metric tracking for various page load metric observers. (Closed)

Created:
3 years, 6 months ago by Bryan McQuade
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, subresource-filter-reviews_chromium.org, csharrison+watch_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UKM metric tracking for various page load metric observers. BUG=

Patch Set 1 #

Patch Set 2 : remove drp #

Patch Set 3 : fix todo #

Patch Set 4 : basic tests #

Patch Set 5 : improve tests #

Patch Set 6 : add subresource filter metrics #

Patch Set 7 : fix #

Patch Set 8 : add subresource filter tests #

Patch Set 9 : rename #

Patch Set 10 : test cleanup #

Patch Set 11 : update #

Patch Set 12 : update #

Patch Set 13 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+496 lines, -194 lines) Patch
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc View 1 2 3 4 5 6 7 8 9 4 chunks +31 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc View 1 2 3 4 5 6 7 8 9 10 chunks +35 lines, -10 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 18 chunks +75 lines, -14 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +55 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +107 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc View 1 2 3 4 5 6 4 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +26 lines, -5 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc View 1 2 3 4 5 6 7 8 9 8 chunks +83 lines, -163 lines 0 comments Download
M services/metrics/public/cpp/ukm_recorder.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 40 (40 generated)
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-07 00:24:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673004/1
3 years, 6 months ago (2017-06-07 00:25:07 UTC) #2
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-07 00:31:35 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673004/20001
3 years, 6 months ago (2017-06-07 00:31:54 UTC) #4
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-07 01:21:07 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673004/40001
3 years, 6 months ago (2017-06-07 01:21:13 UTC) #6
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-07 01:53:31 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673004/60001
3 years, 6 months ago (2017-06-07 01:53:48 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-07 01:55:47 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/226720) ios-simulator-xcode-clang on ...
3 years, 6 months ago (2017-06-07 01:55:48 UTC) #10
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-07 02:11:10 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673004/30008
3 years, 6 months ago (2017-06-07 02:11:28 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-07 02:13:29 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/226733) ios-device-xcode-clang on ...
3 years, 6 months ago (2017-06-07 02:13:30 UTC) #14
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-07 02:21:59 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673004/90001
3 years, 6 months ago (2017-06-07 02:22:15 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-07 02:43:46 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/355131)
3 years, 6 months ago (2017-06-07 02:43:48 UTC) #18
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-07 11:00:02 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673004/110001
3 years, 6 months ago (2017-06-07 11:00:12 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-07 12:17:17 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 6 months ago (2017-06-07 12:17:18 UTC) #22
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-07 13:42:03 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673004/130001
3 years, 6 months ago (2017-06-07 13:42:15 UTC) #24
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-07 13:50:58 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673004/150001
3 years, 6 months ago (2017-06-07 13:51:05 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-07 15:04:11 UTC) #27
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 6 months ago (2017-06-07 15:04:12 UTC) #28
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-08 22:35:13 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673004/170001
3 years, 6 months ago (2017-06-08 22:35:59 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-09 01:13:43 UTC) #31
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 6 months ago (2017-06-09 01:13:44 UTC) #32
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-09 01:25:28 UTC) #33
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673004/190001
3 years, 6 months ago (2017-06-09 01:26:02 UTC) #34
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-09 01:29:05 UTC) #35
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/228567) ios-device-xcode-clang on ...
3 years, 6 months ago (2017-06-09 01:29:06 UTC) #36
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-10 01:18:11 UTC) #37
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673004/210001
3 years, 6 months ago (2017-06-10 01:18:27 UTC) #38
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-10 02:29:34 UTC) #39
commit-bot: I haz the power
3 years, 6 months ago (2017-06-10 02:29:35 UTC) #40 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698