Index: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc |
diff --git a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc |
index 14df9d8d08078306c37aaee5441a450b858f9fe6..29e0d0e40b11cbdd969d5fb18035850c8bd4c5cb 100644 |
--- a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc |
+++ b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc |
@@ -5,11 +5,12 @@ |
#include "chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h" |
#include "base/memory/ptr_util.h" |
+#include "base/metrics/metrics_hashes.h" |
#include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h" |
namespace { |
-const char kDefaultTestUrl[] = "https://google.com"; |
+const char kDefaultTestUrl[] = "https://google.com/"; |
const char kInboxTestUrl[] = "https://inbox.google.com/test"; |
const char kSearchTestUrl[] = "https://www.google.com/search?q=test"; |
@@ -131,6 +132,7 @@ TEST_F(ServiceWorkerPageLoadMetricsObserverTest, NoMetrics) { |
AssertNoInboxHistogramsLogged(); |
AssertNoSearchHistogramsLogged(); |
AssertNoSearchNoSWHistogramsLogged(); |
+ EXPECT_EQ(0ul, ukm_tester().entries_count()); |
} |
TEST_F(ServiceWorkerPageLoadMetricsObserverTest, NoServiceWorker) { |
@@ -144,6 +146,7 @@ TEST_F(ServiceWorkerPageLoadMetricsObserverTest, NoServiceWorker) { |
AssertNoInboxHistogramsLogged(); |
AssertNoSearchHistogramsLogged(); |
AssertNoSearchNoSWHistogramsLogged(); |
+ EXPECT_EQ(0ul, ukm_tester().entries_count()); |
} |
TEST_F(ServiceWorkerPageLoadMetricsObserverTest, WithServiceWorker) { |
@@ -197,6 +200,10 @@ TEST_F(ServiceWorkerPageLoadMetricsObserverTest, WithServiceWorker) { |
histogram_tester().ExpectTotalCount( |
internal::kHistogramServiceWorkerParseStartForwardBackNoStore, 0); |
+ EXPECT_EQ(1ul, ukm_tester().entries_count()); |
+ const ukm::UkmSource* source = ukm_tester().GetSourceForUrl(kDefaultTestUrl); |
+ EXPECT_TRUE(ukm_tester().HasEntry(*source, internal::kUkmServiceWorkerName)); |
+ |
AssertNoInboxHistogramsLogged(); |
AssertNoSearchHistogramsLogged(); |
AssertNoSearchNoSWHistogramsLogged(); |
@@ -242,6 +249,10 @@ TEST_F(ServiceWorkerPageLoadMetricsObserverTest, WithServiceWorkerBackground) { |
// histogram_tester().ExpectTotalCount( |
// internal::kBackgroundHistogramServiceWorkerParseStart, 1); |
+ EXPECT_EQ(1ul, ukm_tester().entries_count()); |
+ const ukm::UkmSource* source = ukm_tester().GetSourceForUrl(kDefaultTestUrl); |
+ EXPECT_TRUE(ukm_tester().HasEntry(*source, internal::kUkmServiceWorkerName)); |
+ |
AssertNoInboxHistogramsLogged(); |
AssertNoSearchHistogramsLogged(); |
AssertNoSearchNoSWHistogramsLogged(); |