chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h - Issue 2924673004: Add UKM metric tracking for various page load metric observers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h

Issue 2924673004: Add UKM metric tracking for various page load metric observers. (Closed)

Patch Set: update Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc ('k') | chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h

index e03159bde00cc9b9bc620cef50165c38004d33ff..b5d275eeb649466f6b9dfdee51caccd76e7fb951 100644

--- a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h

@@ -44,6 +44,7 @@ extern const char

kHistogramServiceWorkerParseStartToFirstContentfulPaintSearch[];

extern const char kHistogramServiceWorkerDomContentLoadedSearch[];

extern const char kHistogramServiceWorkerLoadSearch[];

+extern const char kUkmServiceWorkerName[];

extern const char kHistogramNoServiceWorkerFirstContentfulPaintSearch[];

extern const char kHistogramNoServiceWorkerFirstMeaningfulPaintSearch[];

@@ -78,10 +79,13 @@ class ServiceWorkerPageLoadMetricsObserver

void OnLoadEventStart(

const page_load_metrics::mojom::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& extra_info) override;

+ void OnLoadingBehaviorObserved(

+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;

private:

ui::PageTransition transition_ = ui::PAGE_TRANSITION_LINK;

bool was_no_store_main_resource_ = false;

+ bool logged_ukm_event_ = false;

DISALLOW_COPY_AND_ASSIGN(ServiceWorkerPageLoadMetricsObserver);

};