Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2924673002: Explicitly setting names for scheduler.tough_scheduling_changes stories (Closed)

Created:
3 years, 6 months ago by ashleymarie1
Modified:
3 years, 6 months ago
Reviewers:
nednguyen, Sami, brianderson
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly setting names for scheduler.tough_scheduling_changes stories BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2924673002 Cr-Commit-Position: refs/heads/master@{#477693} Committed: https://chromium.googlesource.com/chromium/src/+/986ad291791882d151f951824774a8f1e276df14

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/perf/page_sets/tough_scheduling_cases.py View 2 chunks +4 lines, -2 lines 2 comments Download

Messages

Total messages: 11 (4 generated)
ashleymarie1
3 years, 6 months ago (2017-06-05 20:30:25 UTC) #2
nednguyen
https://codereview.chromium.org/2924673002/diff/1/tools/perf/page_sets/tough_scheduling_cases.py File tools/perf/page_sets/tough_scheduling_cases.py (right): https://codereview.chromium.org/2924673002/diff/1/tools/perf/page_sets/tough_scheduling_cases.py#newcode15 tools/perf/page_sets/tough_scheduling_cases.py:15: name=url.split('/')[-1]) Does this change any of the existing names?
3 years, 6 months ago (2017-06-05 20:53:49 UTC) #3
ashleymarie1
https://codereview.chromium.org/2924673002/diff/1/tools/perf/page_sets/tough_scheduling_cases.py File tools/perf/page_sets/tough_scheduling_cases.py (right): https://codereview.chromium.org/2924673002/diff/1/tools/perf/page_sets/tough_scheduling_cases.py#newcode15 tools/perf/page_sets/tough_scheduling_cases.py:15: name=url.split('/')[-1]) On 2017/06/05 20:53:49, nednguyen wrote: > Does this ...
3 years, 6 months ago (2017-06-06 13:49:29 UTC) #4
Sami
rs lgtm.
3 years, 6 months ago (2017-06-07 14:35:06 UTC) #5
nednguyen
lgtm
3 years, 6 months ago (2017-06-07 15:45:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924673002/1
3 years, 6 months ago (2017-06-07 15:46:09 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 17:23:24 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/986ad291791882d151f951824774...

Powered by Google App Engine
This is Rietveld 408576698