Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: tools/perf/page_sets/tough_scheduling_cases.py

Issue 2924673002: Explicitly setting names for scheduler.tough_scheduling_changes stories (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/tough_scheduling_cases.py
diff --git a/tools/perf/page_sets/tough_scheduling_cases.py b/tools/perf/page_sets/tough_scheduling_cases.py
index 1a817a1a93930916b2fa44416ccdf43a7c2065e5..b7b6edbaa43c8a0fc5d1532ca403960141c0a8f2 100644
--- a/tools/perf/page_sets/tough_scheduling_cases.py
+++ b/tools/perf/page_sets/tough_scheduling_cases.py
@@ -11,7 +11,8 @@ class ToughSchedulingCasesPage(page_module.Page):
def __init__(self, url, page_set):
super(ToughSchedulingCasesPage, self).__init__(
url=url, page_set=page_set, credentials_path='data/credentials.json',
- shared_page_state_class=shared_page_state.SharedMobilePageState)
+ shared_page_state_class=shared_page_state.SharedMobilePageState,
+ name=url.split('/')[-1])
nednguyen 2017/06/05 20:53:49 Does this change any of the existing names?
ashleymarie1 2017/06/06 13:49:28 Nope doesn't change any of the existing names dis
self.archive_data_file = 'data/tough_scheduling_cases.json'
def RunPageInteractions(self, action_runner):
@@ -396,7 +397,8 @@ class ToughSchedulingCasesPageSet(story.StorySet):
def __init__(self):
super(ToughSchedulingCasesPageSet, self).__init__(
archive_data_file='data/tough_scheduling_cases.json',
- cloud_storage_bucket=story.INTERNAL_BUCKET)
+ cloud_storage_bucket=story.INTERNAL_BUCKET,
+ verify_names=True)
# Why: Simple scrolling baseline
self.AddStory(ToughSchedulingCasesPage(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698