Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2924653002: Fix underspecified closure dependency of js_minify.py (Closed)

Created:
3 years, 6 months ago by wychen
Modified:
3 years, 6 months ago
Reviewers:
flackr
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix underspecified closure dependency of js_minify.py third_party/closure_compiler/compiler/compiler.jar was not in the dependency of grit JS minifier. This caused flaky building behavior and made bisecting for crbug.com/728655 difficult. BUG=728655 Review-Url: https://codereview.chromium.org/2924653002 Cr-Commit-Position: refs/heads/master@{#477176} Committed: https://chromium.googlesource.com/chromium/src/+/e7deaa85c11854d2066e061ed93665ea920f4cbf

Patch Set 1 : Split from https://codereview.chromium.org/2921143002/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/grit/grit_rule.gni View 1 chunk +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
wychen
PTAL
3 years, 6 months ago (2017-06-05 19:04:55 UTC) #2
flackr
lgtm
3 years, 6 months ago (2017-06-05 19:09:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924653002/1
3 years, 6 months ago (2017-06-05 19:13:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/310637)
3 years, 6 months ago (2017-06-06 00:24:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924653002/1
3 years, 6 months ago (2017-06-06 01:11:05 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 03:25:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7deaa85c11854d2066e061ed936...

Powered by Google App Engine
This is Rietveld 408576698