tools/grit/grit_rule.gni - Issue 2924653002: Fix underspecified closure dependency of js_minify.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/grit/grit_rule.gni

Issue 2924653002: Fix underspecified closure dependency of js_minify.py (Closed)

Patch Set: Split from https://codereview.chromium.org/2921143002/ Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/grit/grit_rule.gni

diff --git a/tools/grit/grit_rule.gni b/tools/grit/grit_rule.gni

index 3db7a6c6b210ceb8826faaef6ae3535efb26e601..ca524b6e287df5fb9b18add95f39fa8bb2181565 100644

--- a/tools/grit/grit_rule.gni

+++ b/tools/grit/grit_rule.gni

@@ -402,7 +402,10 @@ template("grit") {

"--js-minifier",

js_minifier_command,

]

- inputs += [ _js_minifier ]

+ inputs += [

+ _js_minifier,

+ "//third_party/closure_compiler/compiler/compiler.jar",

+ ]

}

# Must be after the args are computed since they are re-used.

« no previous file with comments | « no previous file | no next file » | no next file with comments »