Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2924593002: VR: Use system back button behaviour while in ChromeTabbedActivity. (Closed)

Created:
3 years, 6 months ago by mthiesse
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

VR: Use system back button behaviour while in ChromeTabbedActivity. This allows us to behave the same way CTA does when hitting the back button, which includes closing tabs opened by links. However, we disable exiting chrome when the back stack is exhausted. This is important because we don't support manual tab management yet in VR, so we don't want users to get stuck after a link opens in a new tab. Bug: 728725 Change-Id: I5c042bd9f902fdee3db56451de97fe944dcf293d Reviewed-on: https://chromium-review.googlesource.com/519802 Commit-Queue: Michael Thiessen <mthiesse@chromium.org>; Reviewed-by: Yash Malik <ymalik@chromium.org>; Reviewed-by: Ted Choc <tedchoc@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#476760} Review-Url: https://codereview.chromium.org/2924593002 . Cr-Commit-Position: refs/branch-heads/3112@{#151} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/2c81bbb26501c9f5dfa48abefd9c8b80dd161e5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 2 chunks +19 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/url_bar.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_elements/url_bar.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mthiesse
3 years, 6 months ago (2017-06-05 14:36:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c81bbb26501c9f5dfa48abefd9c8b80dd161e5c.

Powered by Google App Engine
This is Rietveld 408576698