Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4124)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Issue 2924593002: VR: Use system back button behaviour while in ChromeTabbedActivity. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
index 012ec0003be4500631d64b3f9d056b60135336e5..f4c0093827b996260f978679a7852531fcf6a40f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
@@ -25,8 +25,10 @@ import org.chromium.base.VisibleForTesting;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
import org.chromium.chrome.browser.ChromeActivity;
+import org.chromium.chrome.browser.ChromeTabbedActivity;
import org.chromium.chrome.browser.NativePage;
import org.chromium.chrome.browser.UrlConstants;
+import org.chromium.chrome.browser.ntp.NewTabPage;
import org.chromium.chrome.browser.tab.EmptyTabObserver;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tab.TabObserver;
@@ -574,14 +576,27 @@ public class VrShellImpl
@CalledByNative
public void navigateBack() {
- mActivity.getToolbarManager().back();
+ if (mActivity instanceof ChromeTabbedActivity) {
+ // TODO(mthiesse): We should do this for custom tabs as well, as back for custom tabs
+ // is also expected to close tabs.
+ ((ChromeTabbedActivity) mActivity).handleBackPressed();
+ } else {
+ mActivity.getToolbarManager().back();
+ }
updateHistoryButtonsVisibility();
}
private void updateHistoryButtonsVisibility() {
- boolean canGoBack = mTab != null && mTab.canGoBack();
- boolean canGoForward = mTab != null && mTab.canGoForward();
- nativeSetHistoryButtonsEnabled(mNativeVrShell, canGoBack, canGoForward);
+ if (mTab == null) {
+ nativeSetHistoryButtonsEnabled(mNativeVrShell, false, false);
+ return;
+ }
+ // Hitting back when on the NTP usually closes Chrome, which we don't allow in VR, so we
+ // just disable the back button.
+ boolean shouldAlwaysGoBack = mActivity instanceof ChromeTabbedActivity
+ && (mNativePage == null || !(mNativePage instanceof NewTabPage));
+ boolean canGoBack = mTab.canGoBack() || shouldAlwaysGoBack;
+ nativeSetHistoryButtonsEnabled(mNativeVrShell, canGoBack, mTab.canGoForward());
}
@CalledByNative

Powered by Google App Engine
This is Rietveld 408576698