supersize: Fix path counts, missing section in clusters

supersize: Fix path counts, missing section in clusters

Print(symbol_group[2:4]) now works more nicely as well.

BUG=681694
Review-Url: https://codereview.chromium.org/2924343004
Cr-Commit-Position: refs/heads/master@{#478620}
Committed: https://chromium.googlesource.com/chromium/src/+/538f8339442bd8ba939a96bb859594be6b61ac00

[agrieve, 2017-06-09 20:28:06]

Description was changed from

==========
supersize: Fix path counts, missing section in clusters

Print(symbol_group[2:4]) now works more nicely as well.

BUG=681694
==========

to

==========
supersize: Fix path counts, missing section in clusters

Print(symbol_group[2:4]) now works more nicely as well.

BUG=681694
==========

[agrieve, 2017-06-09 20:28:06]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[agrieve, 2017-06-09 20:28:18]

On 2017/06/09 20:28:06, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:estevenson@chromium.org

⚰️

[estevenson, 2017-06-09 22:30:19]

lgtm

https://codereview.chromium.org/2924343004/diff/1/tools/binary_size/libsupers...
File tools/binary_size/libsupersize/describe.py (right):

https://codereview.chromium.org/2924343004/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/describe.py:210:
changed.update(added.intersection(removed))
nit: can you maybe add a comment above all the updating describing why this is
necessary?

[agrieve, 2017-06-12 14:37:17]

https://codereview.chromium.org/2924343004/diff/1/tools/binary_size/libsupers...
File tools/binary_size/libsupersize/describe.py (right):

https://codereview.chromium.org/2924343004/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/describe.py:210:
changed.update(added.intersection(removed))
On 2017/06/09 22:30:19, estevenson wrote:
> nit: can you maybe add a comment above all the updating describing why this is
> necessary?

Done.

[agrieve, 2017-06-12 14:37:39]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-06-12 14:37:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
estevenson@chromium.org
Link to the patchset: https://codereview.chromium.org/2924343004/#ps20001
(title: "add comments")

[commit-bot: I haz the power, 2017-06-12 14:37:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 14:54:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497278259096190,
"parent_rev": "543152988268c76df1910d458c0b10775f80c40f", "commit_rev":
"538f8339442bd8ba939a96bb859594be6b61ac00"}

[commit-bot: I haz the power, 2017-06-12 14:54:12]

Description was changed from

==========
supersize: Fix path counts, missing section in clusters

Print(symbol_group[2:4]) now works more nicely as well.

BUG=681694
==========

to

==========
supersize: Fix path counts, missing section in clusters

Print(symbol_group[2:4]) now works more nicely as well.

BUG=681694

Review-Url: https://codereview.chromium.org/2924343004
Cr-Commit-Position: refs/heads/master@{#478620}
Committed:
https://chromium.googlesource.com/chromium/src/+/538f8339442bd8ba939a96bb8595...
==========

[commit-bot: I haz the power, 2017-06-12 14:54:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/538f8339442bd8ba939a96bb8595...