Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: tools/binary_size/libsupersize/diff.py

Issue 2924343004: supersize: Fix path counts, missing section in clusters (Closed)
Patch Set: add comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/libsupersize/describe.py ('k') | tools/binary_size/libsupersize/models.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/libsupersize/diff.py
diff --git a/tools/binary_size/libsupersize/diff.py b/tools/binary_size/libsupersize/diff.py
index 7002afb750652bf4a09f09cd65601a625fb4f9e7..2cc114b2d3eb29a1d13ed872145087f638dda192 100644
--- a/tools/binary_size/libsupersize/diff.py
+++ b/tools/binary_size/libsupersize/diff.py
@@ -32,11 +32,14 @@ def _SymbolKey(symbol):
# "symbol gap 3 (bar)" -> "symbol gaps"
name = re.sub(r'\s+\d+( \(.*\))?$', 's', name)
+ # Use section rather than section_name since clang & gcc use
+ # .data.rel.ro vs .data.rel.ro.local.
if '.' not in name:
- return (symbol.section_name, name)
+ return (symbol.section, name)
+
# Compiler or Linker generated symbol.
name = re.sub(r'[.0-9]', '', name) # Strip out all numbers and dots.
- return (symbol.section_name, name, symbol.object_path)
+ return (symbol.section, name, symbol.object_path)
def _CloneSymbol(sym, size):
« no previous file with comments | « tools/binary_size/libsupersize/describe.py ('k') | tools/binary_size/libsupersize/models.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698