Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2924163004: Revert of Add recently removed iOS CQ unit tests back to FYI. (Closed)

Created:
3 years, 6 months ago by baxley
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add recently removed iOS CQ unit tests back to FYI. (patchset #2 id:20001 of https://codereview.chromium.org/2922253004/ ) Reason for revert: Now that ios_chrome_unittests are back in common_tests.json, fyi bots have an exception for two instances of ios_chrome_unittests. Same with net_unittests. Original issue's description: > Add recently removed iOS CQ unit tests back to FYI. > > Create new fyi_tests.json so we can more easily run different > suites on multiple fyi configurations. > > BUG=728216 > > Review-Url: https://codereview.chromium.org/2922253004 > Cr-Commit-Position: refs/heads/master@{#477528} > Committed: https://chromium.googlesource.com/chromium/src/+/77dac22383dca465e09cfbbb61fadfce83c9eede TBR=rohitrao@chromium.org,smut@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=728216 Review-Url: https://codereview.chromium.org/2924163004 Cr-Commit-Position: refs/heads/master@{#477888} Committed: https://chromium.googlesource.com/chromium/src/+/2fccbd0ee411a58f1092c2c036d614da16ca4730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -70 lines) Patch
M ios/build/bots/chromium.fyi/ios-simulator.json View 1 chunk +0 lines, -60 lines 0 comments Download
D ios/build/bots/tests/fyi_tests.json View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
baxley
Created Revert of Add recently removed iOS CQ unit tests back to FYI.
3 years, 6 months ago (2017-06-08 04:06:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2924163004/1
3 years, 6 months ago (2017-06-08 04:06:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2fccbd0ee411a58f1092c2c036d614da16ca4730
3 years, 6 months ago (2017-06-08 04:36:09 UTC) #6
smut
3 years, 6 months ago (2017-06-08 22:12:44 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698