Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2922253004: Add recently removed iOS CQ unit tests back to FYI. (Closed)

Created:
3 years, 6 months ago by baxley
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add recently removed iOS CQ unit tests back to FYI. Create new fyi_tests.json so we can more easily run different suites on multiple fyi configurations. BUG=728216 Review-Url: https://codereview.chromium.org/2922253004 Cr-Commit-Position: refs/heads/master@{#477528} Committed: https://chromium.googlesource.com/chromium/src/+/77dac22383dca465e09cfbbb61fadfce83c9eede

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove recursive includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M ios/build/bots/chromium.fyi/ios-simulator.json View 1 1 chunk +60 lines, -0 lines 0 comments Download
A ios/build/bots/tests/fyi_tests.json View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
baxley
This is to add tests removed from the CQ back to fyi, so we can ...
3 years, 6 months ago (2017-06-07 00:13:24 UTC) #2
smut
https://codereview.chromium.org/2922253004/diff/1/ios/build/bots/tests/fyi_tests.json File ios/build/bots/tests/fyi_tests.json (right): https://codereview.chromium.org/2922253004/diff/1/ios/build/bots/tests/fyi_tests.json#newcode4 ios/build/bots/tests/fyi_tests.json:4: "include": "common_tests.json" Unfortunately you can't recurse here (include can't ...
3 years, 6 months ago (2017-06-07 00:21:53 UTC) #4
baxley
PTAL! feel free to CQ, if it looks okay. Thanks! https://codereview.chromium.org/2922253004/diff/1/ios/build/bots/tests/fyi_tests.json File ios/build/bots/tests/fyi_tests.json (right): https://codereview.chromium.org/2922253004/diff/1/ios/build/bots/tests/fyi_tests.json#newcode4 ...
3 years, 6 months ago (2017-06-07 01:56:14 UTC) #5
smut
lgtm
3 years, 6 months ago (2017-06-07 01:58:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922253004/20001
3 years, 6 months ago (2017-06-07 01:59:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/77dac22383dca465e09cfbbb61fadfce83c9eede
3 years, 6 months ago (2017-06-07 02:47:25 UTC) #11
baxley
3 years, 6 months ago (2017-06-08 04:06:23 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2924163004/ by baxley@chromium.org.

The reason for reverting is: Now that ios_chrome_unittests are back in
common_tests.json, fyi bots have an exception for two instances of
ios_chrome_unittests. Same with net_unittests..

Powered by Google App Engine
This is Rietveld 408576698