Remove socket performance watcher factory from URL request context builder

Remove socket performance watcher factory from URL request context builder

BUG=704339, 731723
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2924163003
Cr-Commit-Position: refs/heads/master@{#478334}
Committed: https://chromium.googlesource.com/chromium/src/+/d8ef10af1a1f8f9adc05df7c796bd2944f2dfd3a

[tbansal1, 2017-06-07 23:58:24]

Description was changed from

==========
Separate out SPW

BUG=
==========

to

==========
Separate out SPW

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-06-07 23:58:35]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 23:59:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 00:12:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 00:12:36]

Dry run: Try jobs failed on following builders:
  android_cronet_tester on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[tbansal1, 2017-06-08 15:50:08]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 15:50:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 15:52:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 15:52:33]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tbansal1, 2017-06-08 20:05:58]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 20:06:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 20:21:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 20:21:27]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[tbansal1, 2017-06-08 21:16:33]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[tbansal1, 2017-06-08 21:16:36]

Patchset #1 (id:1) has been deleted

[tbansal1, 2017-06-08 21:16:42]

Patchset #1 (id:20001) has been deleted

[tbansal1, 2017-06-08 21:16:50]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-06-08 21:17:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 21:20:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 21:20:19]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tbansal1, 2017-06-08 21:23:15]

Patchset #1 (id:60001) has been deleted

[tbansal1, 2017-06-08 21:23:58]

Description was changed from

==========
Separate out SPW

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Remove socket performance watcher factory from URL request context builder

BUG=704339
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-06-09 05:23:35]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 05:23:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 06:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 06:41:37]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-06-09 14:12:59]

Patchset #1 (id:80001) has been deleted

[tbansal1, 2017-06-09 14:22:20]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 14:22:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-06-09 14:37:10]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 14:37:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-06-09 15:51:06]

Patchset #2 (id:120001) has been deleted

[tbansal1, 2017-06-09 15:51:21]

Patchset #1 (id:100001) has been deleted

[tbansal1, 2017-06-09 15:51:42]

Description was changed from

==========
Remove socket performance watcher factory from URL request context builder

BUG=704339
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Remove socket performance watcher factory from URL request context builder

BUG=704339, 731723
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-06-09 15:52:37]

tbansal@chromium.org changed reviewers:
+ mmenke@chromium.org

[tbansal1, 2017-06-09 15:52:37]

mmenke: ptal. Thanks.

[commit-bot: I haz the power, 2017-06-09 15:57:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 15:57:19]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-06-09 16:32:13]

https://codereview.chromium.org/2924163003/diff/140001/net/url_request/url_re...
File net/url_request/url_request_context_builder.cc (right):

https://codereview.chromium.org/2924163003/diff/140001/net/url_request/url_re...
net/url_request/url_request_context_builder.cc:241:
->GetSocketPerformanceWatcherFactory();
The "session_context.socket_performance_watcher_factory =" line can be removed
from profile_io_data now, too.

https://codereview.chromium.org/2924163003/diff/140001/net/url_request/url_re...
net/url_request/url_request_context_builder.cc:241:
->GetSocketPerformanceWatcherFactory();
Also, it looks like socket_performance_watcher_factory was not being hooked up
to the system request context, but the NQE is.  I assume that means this CL is
fixing a bug?

[tbansal1, 2017-06-09 16:45:06]

ptal. Thanks.

https://codereview.chromium.org/2924163003/diff/140001/net/url_request/url_re...
File net/url_request/url_request_context_builder.cc (right):

https://codereview.chromium.org/2924163003/diff/140001/net/url_request/url_re...
net/url_request/url_request_context_builder.cc:241:
->GetSocketPerformanceWatcherFactory();
On 2017/06/09 16:32:13, mmenke wrote:
> The "session_context.socket_performance_watcher_factory =" line can be removed
> from profile_io_data now, too.

Done.

https://codereview.chromium.org/2924163003/diff/140001/net/url_request/url_re...
net/url_request/url_request_context_builder.cc:241:
->GetSocketPerformanceWatcherFactory();
On 2017/06/09 16:32:13, mmenke wrote:
> Also, it looks like socket_performance_watcher_factory was not being hooked up
> to the system request context, but the NQE is.  I assume that means this CL is
> fixing a bug?

Yes, for some contexts (e.g., off the record), SPWF was null while NQE was not.
There was no reason to set NQE while keeping SPWF null.

[mmenke, 2017-06-09 16:50:02]

Thanks!  LGTM!

[tbansal1, 2017-06-09 16:50:22]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 16:50:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 18:04:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 18:04:11]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-06-09 18:04:55]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2017-06-09 18:05:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 18:10:18]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1497031495416690,
"parent_rev": "2a94285989c6c2ccd5fe330cc7766596a2de5afe", "commit_rev":
"d8ef10af1a1f8f9adc05df7c796bd2944f2dfd3a"}

[commit-bot: I haz the power, 2017-06-09 18:10:27]

Description was changed from

==========
Remove socket performance watcher factory from URL request context builder

BUG=704339, 731723
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Remove socket performance watcher factory from URL request context builder

BUG=704339, 731723
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2924163003
Cr-Commit-Position: refs/heads/master@{#478334}
Committed:
https://chromium.googlesource.com/chromium/src/+/d8ef10af1a1f8f9adc05df7c796b...
==========

[commit-bot: I haz the power, 2017-06-09 18:10:28]

Committed patchset #2 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/d8ef10af1a1f8f9adc05df7c796b...