Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: components/cronet/android/cronet_url_request_context_adapter.cc

Issue 2924163003: Remove socket performance watcher factory from URL request context builder (Closed)
Patch Set: ps Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_io_data.cc ('k') | net/url_request/url_request_context_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/cronet_url_request_context_adapter.cc
diff --git a/components/cronet/android/cronet_url_request_context_adapter.cc b/components/cronet/android/cronet_url_request_context_adapter.cc
index ffe89c8b13c441a061f730d972b66b739de0b2c9..e8e65b4f1015fadeeceb35b90f27fd5f11111618 100644
--- a/components/cronet/android/cronet_url_request_context_adapter.cc
+++ b/components/cronet/android/cronet_url_request_context_adapter.cc
@@ -690,10 +690,6 @@ void CronetURLRequestContextAdapter::InitializeOnNetworkThread(
std::unique_ptr<net::ExternalEstimateProvider>(),
base::MakeUnique<net::NetworkQualityEstimatorParams>(variation_params),
g_net_log.Get().net_log());
- // Set the socket performance watcher factory so that network quality
- // estimator is notified of socket performance metrics from TCP and QUIC.
- context_builder.set_socket_performance_watcher_factory(
- network_quality_estimator_->GetSocketPerformanceWatcherFactory());
network_quality_estimator_->AddEffectiveConnectionTypeObserver(this);
network_quality_estimator_->AddRTTAndThroughputEstimatesObserver(this);
@@ -707,6 +703,8 @@ void CronetURLRequestContextAdapter::InitializeOnNetworkThread(
network_qualities_prefs_manager_->InitializeOnNetworkThread(
network_quality_estimator_.get());
}
+ context_builder.set_network_quality_estimator(
+ network_quality_estimator_.get());
}
context_ = context_builder.Build();
@@ -714,9 +712,6 @@ void CronetURLRequestContextAdapter::InitializeOnNetworkThread(
context_->set_check_cleartext_permitted(true);
context_->set_enable_brotli(config->enable_brotli);
- if (network_quality_estimator_)
- context_->set_network_quality_estimator(network_quality_estimator_.get());
-
if (config->load_disable_cache)
default_load_flags_ |= net::LOAD_DISABLE_CACHE;
« no previous file with comments | « chrome/browser/profiles/profile_io_data.cc ('k') | net/url_request/url_request_context_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698