Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2923983002: [tools] Properly handle different GOMA_DIR in gm.py. (Closed)

Created:
3 years, 6 months ago by Benedikt Meurer
Modified:
3 years, 6 months ago
Reviewers:
Jarin, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Properly handle different GOMA_DIR in gm.py. R=jarin@chromium.org, jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2923983002 Cr-Commit-Position: refs/heads/master@{#45753} Committed: https://chromium.googlesource.com/v8/v8/+/5005eea85a8f47c11e9865847867a115c4417ed9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M tools/dev/gm.py View 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 6 months ago (2017-06-07 08:46:01 UTC) #1
Jakob Kummerow
LGTM. I guess the existing check for GOMADIR was a typo (and should have been ...
3 years, 6 months ago (2017-06-07 08:53:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923983002/1
3 years, 6 months ago (2017-06-07 09:03:59 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 09:08:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5005eea85a8f47c11e9865847867a115c44...

Powered by Google App Engine
This is Rietveld 408576698