Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: tools/dev/gm.py

Issue 2923983002: [tools] Properly handle different GOMA_DIR in gm.py. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dev/gm.py
diff --git a/tools/dev/gm.py b/tools/dev/gm.py
index 8de7ddfe613f54e347b7339a8dda3664b85c05c2..5e899330d0a781b9e2e88505ccaee82beaefbfc0 100755
--- a/tools/dev/gm.py
+++ b/tools/dev/gm.py
@@ -87,6 +87,8 @@ def DetectGoma():
home_goma = os.path.expanduser("~/goma")
if os.path.exists(home_goma):
return home_goma
+ if os.environ.get("GOMA_DIR"):
+ return os.environ.get("GOMA_DIR")
if os.environ.get("GOMADIR"):
return os.environ.get("GOMADIR")
return None
@@ -102,11 +104,12 @@ is_component_build = false
is_debug = false
%s
use_goma = {GOMA}
+goma_dir = \"{GOMA_DIR}\"
v8_enable_backtrace = true
v8_enable_disassembler = true
v8_enable_object_print = true
v8_enable_verify_heap = true
-""".replace("{GOMA}", USE_GOMA)
+""".replace("{GOMA}", USE_GOMA).replace("{GOMA_DIR}", GOMADIR)
DEBUG_ARGS_TEMPLATE = """\
is_component_build = true
@@ -114,10 +117,11 @@ is_debug = true
symbol_level = 2
%s
use_goma = {GOMA}
+goma_dir = \"{GOMA_DIR}\"
v8_enable_backtrace = true
v8_enable_slow_dchecks = true
v8_optimized_debug = false
-""".replace("{GOMA}", USE_GOMA)
+""".replace("{GOMA}", USE_GOMA).replace("{GOMA_DIR}", GOMADIR)
OPTDEBUG_ARGS_TEMPLATE = """\
is_component_build = true
@@ -125,10 +129,11 @@ is_debug = true
symbol_level = 1
%s
use_goma = {GOMA}
+goma_dir = \"{GOMA_DIR}\"
v8_enable_backtrace = true
v8_enable_verify_heap = true
v8_optimized_debug = true
-""".replace("{GOMA}", USE_GOMA)
+""".replace("{GOMA}", USE_GOMA).replace("{GOMA_DIR}", GOMADIR)
ARGS_TEMPLATES = {
"release": RELEASE_ARGS_TEMPLATE,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698