Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2923953002: Remove early progress center item when no files are copied. (Closed)

Created:
3 years, 6 months ago by tetsui
Modified:
3 years, 6 months ago
Reviewers:
yamaguchi, fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Remove early progress center item when no files are copied. Early progress center feedback for copy / move task were added in eab6fcca575e4781af96c9f1b81265e05f370744, but there was a regression which progress center item remains in a case where no files are copied or moved. BUG=729726 NOTRY=true NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2923123002 Cr-Original-Commit-Position: refs/heads/master@{#477218} Review-Url: https://codereview.chromium.org/2923953002 Cr-Commit-Position: refs/branch-heads/3112@{#272} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/02fc96ad503355e0f4d1988f12dab6f56508d9d6

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
tetsui
PTAL. Thanks! (cherry-picked)
3 years, 6 months ago (2017-06-07 07:31:16 UTC) #2
tetsui
Verified on the latest Canary build. Version 61.0.3123.0 canary (64-bit) Platform 9628.0.0 (Official Build) canary-channel ...
3 years, 6 months ago (2017-06-09 01:36:05 UTC) #3
fukino
lgtm. Thank you for verifying it!
3 years, 6 months ago (2017-06-09 04:12:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923953002/1
3 years, 6 months ago (2017-06-09 04:13:38 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 6 months ago (2017-06-09 04:13:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923953002/20001
3 years, 6 months ago (2017-06-09 04:19:25 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 04:20:07 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/02fc96ad503355e0f4d1988f12da...

Powered by Google App Engine
This is Rietveld 408576698