Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2923123002:
Remove early progress center item when no files are copied. (Closed)
DescriptionRemove early progress center item when no files are copied.
Early progress center feedback for copy / move task were added in
eab6fcca575e4781af96c9f1b81265e05f370744, but there was a regression
which progress center item remains in a case where no files are copied
or moved.
BUG=729726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2923123002
Cr-Commit-Position: refs/heads/master@{#477218}
Committed: https://chromium.googlesource.com/chromium/src/+/4167dd7b647e54785386b1eebf66a94c3c5ce6db
Patch Set 1 #
Total comments: 3
Patch Set 2 : Resolve the review comment. #Messages
Total messages: 18 (12 generated)
Description was changed from ========== Remove early progress center item when no files are copied. Early progress center feedback for copy / move task were added in eab6fcca575e4781af96c9f1b81265e05f370744, but there was a regression which progress center item remains in a case where no files are copied or moved. BUG=729726 ========== to ========== Remove early progress center item when no files are copied. Early progress center feedback for copy / move task were added in eab6fcca575e4781af96c9f1b81265e05f370744, but there was a regression which progress center item remains in a case where no files are copied or moved. BUG=729726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by tetsui@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tetsui@chromium.org changed reviewers: + fukino@chromium.org, yamaguchi@chromium.org
Sorry for my mistake. fukino@: Please take a look. Thank you. yamaguchi@: Thank you for investigation.
https://codereview.chromium.org/2923123002/diff/1/ui/file_manager/file_manage... File ui/file_manager/file_manager/foreground/js/file_transfer_controller.js (right): https://codereview.chromium.org/2923123002/diff/1/ui/file_manager/file_manage... ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:542: FileTransferController.URLsToEntriesWithAccess(sourceURLs) FYI, URLsToEntriesWithAccess will also never be rejected https://codesearch.chromium.org/chromium/src/ui/file_manager/file_manager/com... https://codesearch.chromium.org/chromium/src/ui/file_manager/file_manager/for...
lgtm with a nit. Could you add TEST= line in the bug description about how you confirmed the change? https://codereview.chromium.org/2923123002/diff/1/ui/file_manager/file_manage... File ui/file_manager/file_manager/foreground/js/file_transfer_controller.js (right): https://codereview.chromium.org/2923123002/diff/1/ui/file_manager/file_manage... ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:567: item.state = ProgressItemState.COMPLETED; nit: ProgressItemState.CANCELED might sound better as it is more consistent with the rejected value: ABORT.
Thank you! https://codereview.chromium.org/2923123002/diff/1/ui/file_manager/file_manage... File ui/file_manager/file_manager/foreground/js/file_transfer_controller.js (right): https://codereview.chromium.org/2923123002/diff/1/ui/file_manager/file_manage... ui/file_manager/file_manager/foreground/js/file_transfer_controller.js:567: item.state = ProgressItemState.COMPLETED; On 2017/06/06 05:40:03, fukino wrote: > nit: ProgressItemState.CANCELED might sound better as it is more consistent with > the rejected value: ABORT. Done.
The CQ bit was checked by tetsui@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tetsui@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org Link to the patchset: https://codereview.chromium.org/2923123002/#ps20001 (title: "Resolve the review comment.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496731294504180,
"parent_rev": "2ba96b06da25d3e9e905a3a6d2c22f347ecdc9fe", "commit_rev":
"4167dd7b647e54785386b1eebf66a94c3c5ce6db"}
Message was sent while issue was closed.
Description was changed from ========== Remove early progress center item when no files are copied. Early progress center feedback for copy / move task were added in eab6fcca575e4781af96c9f1b81265e05f370744, but there was a regression which progress center item remains in a case where no files are copied or moved. BUG=729726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Remove early progress center item when no files are copied. Early progress center feedback for copy / move task were added in eab6fcca575e4781af96c9f1b81265e05f370744, but there was a regression which progress center item remains in a case where no files are copied or moved. BUG=729726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2923123002 Cr-Commit-Position: refs/heads/master@{#477218} Committed: https://chromium.googlesource.com/chromium/src/+/4167dd7b647e54785386b1eebf66... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4167dd7b647e54785386b1eebf66... |
