Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2923903002: Reject certificates that contain unknown policy qualifiers if the (Closed)

Created:
3 years, 6 months ago by eroman
Modified:
3 years, 6 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reject certificates that contain unknown policy qualifiers if the extension was marked critical. BUG=634453 Review-Url: https://codereview.chromium.org/2923903002 Cr-Commit-Position: refs/heads/master@{#477500} Committed: https://chromium.googlesource.com/chromium/src/+/178f2c6485a8e541d554eb1d14803f0d366bc715

Patch Set 1 #

Patch Set 2 : no changes #

Patch Set 3 : fix typo #

Patch Set 4 : update ios files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+925 lines, -63 lines) Patch
M net/BUILD.gn View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M net/cert/internal/certificate_policies.h View 1 chunk +11 lines, -5 lines 0 comments Download
M net/cert/internal/certificate_policies.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M net/cert/internal/certificate_policies_unittest.cc View 2 chunks +68 lines, -33 lines 0 comments Download
M net/cert/internal/parsed_certificate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/cert/internal/verify_certificate_chain.cc View 2 chunks +27 lines, -16 lines 0 comments Download
M net/cert/internal/verify_certificate_chain_typed_unittest.h View 2 chunks +9 lines, -1 line 0 comments Download
A net/data/verify_certificate_chain_unittest/unknown-critical-policy-qualifier/chain.pem View 1 chunk +277 lines, -0 lines 0 comments Download
A net/data/verify_certificate_chain_unittest/unknown-critical-policy-qualifier/generate-chains.py View 1 chunk +28 lines, -0 lines 0 comments Download
A net/data/verify_certificate_chain_unittest/unknown-critical-policy-qualifier/keys/Intermediate.key View 1 chunk +28 lines, -0 lines 0 comments Download
A net/data/verify_certificate_chain_unittest/unknown-critical-policy-qualifier/keys/Root.key View 1 chunk +28 lines, -0 lines 0 comments Download
A net/data/verify_certificate_chain_unittest/unknown-critical-policy-qualifier/keys/Target.key View 1 chunk +28 lines, -0 lines 0 comments Download
A net/data/verify_certificate_chain_unittest/unknown-critical-policy-qualifier/main.test View 1 chunk +10 lines, -0 lines 0 comments Download
A net/data/verify_certificate_chain_unittest/unknown-non-critical-policy-qualifier/chain.pem View 1 2 1 chunk +276 lines, -0 lines 0 comments Download
A net/data/verify_certificate_chain_unittest/unknown-non-critical-policy-qualifier/generate-chains.py View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A net/data/verify_certificate_chain_unittest/unknown-non-critical-policy-qualifier/keys/Intermediate.key View 1 chunk +28 lines, -0 lines 0 comments Download
A net/data/verify_certificate_chain_unittest/unknown-non-critical-policy-qualifier/keys/Root.key View 1 chunk +28 lines, -0 lines 0 comments Download
A net/data/verify_certificate_chain_unittest/unknown-non-critical-policy-qualifier/keys/Target.key View 1 chunk +28 lines, -0 lines 0 comments Download
A net/data/verify_certificate_chain_unittest/unknown-non-critical-policy-qualifier/main.test View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
eroman
3 years, 6 months ago (2017-06-06 21:55:09 UTC) #3
mattm
lgtm
3 years, 6 months ago (2017-06-06 23:08:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923903002/60001
3 years, 6 months ago (2017-06-06 23:38:25 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 01:03:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/178f2c6485a8e541d554eb1d1480...

Powered by Google App Engine
This is Rietveld 408576698