Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: net/cert/internal/verify_certificate_chain_typed_unittest.h

Issue 2923903002: Reject certificates that contain unknown policy qualifiers if the (Closed)
Patch Set: update ios files Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/verify_certificate_chain_typed_unittest.h
diff --git a/net/cert/internal/verify_certificate_chain_typed_unittest.h b/net/cert/internal/verify_certificate_chain_typed_unittest.h
index 9135c9ce1f74d86c259b3d1de6120044fafd0f65..9175829b09d88a4c96390b0e6118e07b440c4633 100644
--- a/net/cert/internal/verify_certificate_chain_typed_unittest.h
+++ b/net/cert/internal/verify_certificate_chain_typed_unittest.h
@@ -153,6 +153,13 @@ TYPED_TEST_P(VerifyCertificateChainSingleRootTest, KeyRollover) {
this->RunTest("key-rollover/newchain.test");
}
+// Test coverage of policies comes primarily from the PKITS tests. The
+// tests here only cover aspects not already tested by PKITS.
+TYPED_TEST_P(VerifyCertificateChainSingleRootTest, Policies) {
+ this->RunTest("unknown-critical-policy-qualifier/main.test");
+ this->RunTest("unknown-non-critical-policy-qualifier/main.test");
+}
+
// TODO(eroman): Add test that invalid validity dates where the day or month
// ordinal not in range, like "March 39, 2016" are rejected.
@@ -172,7 +179,8 @@ REGISTER_TYPED_TEST_CASE_P(VerifyCertificateChainSingleRootTest,
ExtendedKeyUsage,
IssuerAndSubjectNotByteForByteEqual,
TrustAnchorNotSelfSigned,
- KeyRollover);
+ KeyRollover,
+ Policies);
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698