[turbofan] Properly support Number feedback for binary operators.

[turbofan] Properly support Number feedback for binary operators.

Previously Ignition would collect precise Number feedback for binary
operators, but TurboFan would just ignore that and treat it the same as
NumberOrOddball. That however generates a lot of unnecessary code, plus
it defeats redundancy elimination if the same input is also used by
compare operations, which do properly distinguish feedback Number and
NumberOrOddball.

This CL adds the missing bits to connect the existing functionality
properly, i.e. adding the missing BinaryOperationHint and using the
NumberOperationHint::kNumber in the representation selection for tagged
inputs.

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2923543003
Cr-Commit-Position: refs/heads/master@{#45732}
Committed: https://chromium.googlesource.com/v8/v8/+/8a150262708e0dcca1ce76abc891a9be461be8d6

[Benedikt Meurer, 2017-06-06 12:40:11]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 12:40:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-06-06 12:49:50]

lgtm

[Benedikt Meurer, 2017-06-06 12:50:19]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-06-06 12:50:23]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-06-06 12:50:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 13:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 13:20:04]

Try jobs failed on following builders:
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux64_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)

[Benedikt Meurer, 2017-06-06 13:23:50]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 13:23:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-06-06 13:23:58]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-06-06 13:24:01]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2017-06-06 13:24:01]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2923543003/#ps20001
(title: "Improve DCHECK.")

[commit-bot: I haz the power, 2017-06-06 13:24:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 14:06:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496755441445190,
"parent_rev": "bdf0ea99dffa3da5cca81da6d6a48a5ac31862e0", "commit_rev":
"8a150262708e0dcca1ce76abc891a9be461be8d6"}

[commit-bot: I haz the power, 2017-06-06 14:06:19]

Description was changed from

==========
[turbofan] Properly support Number feedback for binary operators.

Previously Ignition would collect precise Number feedback for binary
operators, but TurboFan would just ignore that and treat it the same as
NumberOrOddball. That however generates a lot of unnecessary code, plus
it defeats redundancy elimination if the same input is also used by
compare operations, which do properly distinguish feedback Number and
NumberOrOddball.

This CL adds the missing bits to connect the existing functionality
properly, i.e. adding the missing BinaryOperationHint and using the
NumberOperationHint::kNumber in the representation selection for tagged
inputs.

R=jarin@chromium.org
==========

to

==========
[turbofan] Properly support Number feedback for binary operators.

Previously Ignition would collect precise Number feedback for binary
operators, but TurboFan would just ignore that and treat it the same as
NumberOrOddball. That however generates a lot of unnecessary code, plus
it defeats redundancy elimination if the same input is also used by
compare operations, which do properly distinguish feedback Number and
NumberOrOddball.

This CL adds the missing bits to connect the existing functionality
properly, i.e. adding the missing BinaryOperationHint and using the
NumberOperationHint::kNumber in the representation selection for tagged
inputs.

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2923543003
Cr-Commit-Position: refs/heads/master@{#45732}
Committed:
https://chromium.googlesource.com/v8/v8/+/8a150262708e0dcca1ce76abc891a9be461...
==========

[commit-bot: I haz the power, 2017-06-06 14:06:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/8a150262708e0dcca1ce76abc891a9be461...