src/compiler/js-type-hint-lowering.cc - Issue 2923543003: [turbofan] Properly support Number feedback for binary operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-type-hint-lowering.cc

Issue 2923543003: [turbofan] Properly support Number feedback for binary operators. (Closed)

Patch Set: Improve DCHECK. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-type-hint-lowering.cc

diff --git a/src/compiler/js-type-hint-lowering.cc b/src/compiler/js-type-hint-lowering.cc

index b1ce30521351dfc276aa7df05f468aabf66b27c9..b1fd40097997b40dde296a8e40936761118752a3 100644

--- a/src/compiler/js-type-hint-lowering.cc

+++ b/src/compiler/js-type-hint-lowering.cc

@@ -25,6 +25,9 @@ bool BinaryOperationHintToNumberOperationHint(

case BinaryOperationHint::kSigned32:

*number_hint = NumberOperationHint::kSigned32;

return true;

+ case BinaryOperationHint::kNumber:

+ *number_hint = NumberOperationHint::kNumber;

+ return true;

case BinaryOperationHint::kNumberOrOddball:

*number_hint = NumberOperationHint::kNumberOrOddball;

return true;

« no previous file with comments | « src/compiler/js-operator.cc ('k') | src/compiler/js-typed-lowering.cc » ('j') | no next file with comments »