Explicitly setting names for media story sets

Explicitly setting names for media story sets

BUG=chromium:720002
Review-Url: https://codereview.chromium.org/2923543002
Cr-Commit-Position: refs/heads/master@{#477022}
Committed: https://chromium.googlesource.com/chromium/src/+/4544e34e0534fb77aa77cad8ce76b665dbf229b2

[ashleymarie1, 2017-06-05 14:02:46]

Description was changed from

==========
Explicitly setting names for media story sets

BUG=chromium:720002
==========

to

==========
Explicitly setting names for media story sets

BUG=chromium:720002
==========

[ashleymarie1, 2017-06-05 14:02:46]

ashleymarie@chromium.org changed reviewers:
+ crouleau@chromium.org, johnchen@chromium.org, nednguyen@google.com

[nednguyen, 2017-06-05 14:06:04]

lgtm if Caleb is happy

[johnchen, 2017-06-05 14:11:52]

https://codereview.chromium.org/2923543002/diff/1/tools/perf/page_sets/media_...
File tools/perf/page_sets/media_cns_cases.py (right):

https://codereview.chromium.org/2923543002/diff/1/tools/perf/page_sets/media_...
tools/perf/page_sets/media_cns_cases.py:121: print name
Is "print name" intended to be permanent, or just for debugging?

https://codereview.chromium.org/2923543002/diff/1/tools/perf/page_sets/tough_...
File tools/perf/page_sets/tough_video_cases.py (right):

https://codereview.chromium.org/2923543002/diff/1/tools/perf/page_sets/tough_...
tools/perf/page_sets/tough_video_cases.py:74:
name='video.html?src=crowd.ogg&type=audio')
Any reason we can't use url.split('/')[-1], as in mse_cases.py?

[ashleymarie1, 2017-06-05 14:16:15]

https://codereview.chromium.org/2923543002/diff/1/tools/perf/page_sets/media_...
File tools/perf/page_sets/media_cns_cases.py (right):

https://codereview.chromium.org/2923543002/diff/1/tools/perf/page_sets/media_...
tools/perf/page_sets/media_cns_cases.py:121: print name
On 2017/06/05 14:11:52, johnchen wrote:
> Is "print name" intended to be permanent, or just for debugging?

Just for debugging; I saw this and uploaded a second patch set right after
sending for review :)

https://codereview.chromium.org/2923543002/diff/1/tools/perf/page_sets/tough_...
File tools/perf/page_sets/tough_video_cases.py (right):

https://codereview.chromium.org/2923543002/diff/1/tools/perf/page_sets/tough_...
tools/perf/page_sets/tough_video_cases.py:74:
name='video.html?src=crowd.ogg&type=audio')
On 2017/06/05 14:11:52, johnchen wrote:
> Any reason we can't use url.split('/')[-1], as in mse_cases.py?

I wasn't sure if you were going to want to change some of these at any point and
figured it was worth splitting them out. I'll pull the name definition into line
38 and reupload

[ashleymarie1, 2017-06-05 14:25:32]

Please take another look, thanks!

[johnchen, 2017-06-05 14:29:23]

LGTM, but please wait for Caleb to take a look.

[CalebRouleau, 2017-06-05 15:59:42]

LGTM. Thank you for improving this!

[ashleymarie1, 2017-06-05 16:08:56]

The CQ bit was checked by ashleymarie@chromium.org

[ashleymarie1, 2017-06-05 16:08:57]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2923543002/#ps40001
(title: "Explicitly setting names for media story sets")

[commit-bot: I haz the power, 2017-06-05 16:09:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 17:58:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496678936643090,
"parent_rev": "1b0342b55e0e32ab1f4775284098b9cc243e878a", "commit_rev":
"4544e34e0534fb77aa77cad8ce76b665dbf229b2"}

[commit-bot: I haz the power, 2017-06-05 17:58:22]

Description was changed from

==========
Explicitly setting names for media story sets

BUG=chromium:720002
==========

to

==========
Explicitly setting names for media story sets

BUG=chromium:720002

Review-Url: https://codereview.chromium.org/2923543002
Cr-Commit-Position: refs/heads/master@{#477022}
Committed:
https://chromium.googlesource.com/chromium/src/+/4544e34e0534fb77aa77cad8ce76...
==========

[commit-bot: I haz the power, 2017-06-05 17:58:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4544e34e0534fb77aa77cad8ce76...