Explicitly setting names for media story sets

tools/perf/page_sets/tough_video_cases.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 from telemetry.page import page as page_module
 from telemetry import story
 
 _PAGE_TAGS_LIST = [
     # Audio codecs:
     'pcm',
     'mp3',
@@ skipping 12 matching lines @@
     'is_50fps',
     'is_4k',
     # Play action
     'seek',
     'normal_play',
 ]
 
 
 class ToughVideoCasesPage(page_module.Page):
 
-  def __init__(self, url, page_set, tags):
+  def __init__(self, url, page_set, tags, name):
     if tags:
       for t in tags:
         assert t in _PAGE_TAGS_LIST
     super(ToughVideoCasesPage, self).__init__(
-        url=url, page_set=page_set, tags=tags)
+        url=url, page_set=page_set, tags=tags, name=name)
 
   def PlayAction(self, action_runner):
     # Play the media until it has finished or it times out.
     action_runner.PlayMedia(playing_event_timeout_in_seconds=60,
                             ended_event_timeout_in_seconds=60)
     # Generate memory dump for memoryMetric.
     if self.page_set.measure_memory:
       action_runner.MeasureMemory()
 
   def SeekBeforeAndAfterPlayhead(self, action_runner,
@@ skipping 14 matching lines @@
     if self.page_set.measure_memory:
       action_runner.MeasureMemory()
 
 
 class Page2(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page2, self).__init__(
       url='file://tough_video_cases/video.html?src=crowd.ogg&type=audio',
       page_set=page_set,
-      tags=['vorbis', 'audio_only'])
+      tags=['vorbis', 'audio_only'],
+      name='video.html?src=crowd.ogg&type=audio')

[johnchen, 2017/06/05 14:11:52]

Any reason we can't use url.split('/')[-1], as in mse_cases.py?

[ashleymarie1, 2017/06/05 14:16:15]

I wasn't sure if you were going to want to change some of these at any point and
figured it was worth splitting them out. I'll pull the name definition into line
38 and reupload

 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page4(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page4, self).__init__(
       url='file://tough_video_cases/video.html?src=crowd1080.webm',
       page_set=page_set,
-      tags=['is_50fps', 'vp8', 'vorbis', 'audio_video', 'normal_play'])
+      tags=['is_50fps', 'vp8', 'vorbis', 'audio_video', 'normal_play'],
+      name='video.html?src=crowd1080.webm')
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page7(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page7, self).__init__(
       url='file://tough_video_cases/video.html?src=tulip2.ogg&type=audio',
       page_set=page_set,
-      tags=['vorbis', 'audio_only', 'normal_play'])
+      tags=['vorbis', 'audio_only', 'normal_play'],
+      name='video.html?src=tulip2.ogg&type=audio')
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page8(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page8, self).__init__(
       url='file://tough_video_cases/video.html?src=tulip2.wav&type=audio',
       page_set=page_set,
-      tags=['pcm', 'audio_only', 'normal_play'])
+      tags=['pcm', 'audio_only', 'normal_play'],
+      name='video.html?src=tulip2.wav&type=audio')
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page11(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page11, self).__init__(
       url='file://tough_video_cases/video.html?src=crowd1080.mp4',
       page_set=page_set,
-      tags=['is_50fps', 'h264', 'aac', 'audio_video', 'normal_play'])
+      tags=['is_50fps', 'h264', 'aac', 'audio_video', 'normal_play'],
+      name='video.html?src=crowd1080.mp4')
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page12(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page12, self).__init__(
       url='file://tough_video_cases/video.html?src=crowd2160.mp4',
       page_set=page_set,
-      tags=['is_4k', 'is_50fps', 'h264', 'aac', 'audio_video', 'normal_play'])
+      tags=['is_4k', 'is_50fps', 'h264', 'aac', 'audio_video', 'normal_play'],
+      name='video.html?src=crowd2160.mp4')
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page13(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page13, self).__init__(
       url='file://tough_video_cases/video.html?src=tulip2.mp3&type=audio',
       page_set=page_set,
-      tags=['mp3', 'audio_only', 'normal_play'])
+      tags=['mp3', 'audio_only', 'normal_play'],
+      name='video.html?src=tulip2.mp3&type=audio')
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page14(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page14, self).__init__(
       url='file://tough_video_cases/video.html?src=tulip2.mp4',
       page_set=page_set,
-      tags=['h264', 'aac', 'audio_video', 'normal_play'])
+      tags=['h264', 'aac', 'audio_video', 'normal_play'],
+      name='video.html?src=tulip2.mp4')
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page15(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page15, self).__init__(
       url='file://tough_video_cases/video.html?src=tulip2.m4a&type=audio',
       page_set=page_set,
-      tags=['aac', 'audio_only', 'normal_play'])
+      tags=['aac', 'audio_only', 'normal_play'],
+      name='video.html?src=tulip2.m4a&type=audio')
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page16(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page16, self).__init__(
       url='file://tough_video_cases/video.html?src=garden2_10s.webm',
       page_set=page_set,
-      tags=['is_4k', 'vp8', 'vorbis', 'audio_video', 'normal_play'])
+      tags=['is_4k', 'vp8', 'vorbis', 'audio_video', 'normal_play'],
+      name='video.html?src=garden2_10s.webm')
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page17(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page17, self).__init__(
       url='file://tough_video_cases/video.html?src=garden2_10s.mp4',
       page_set=page_set,
-      tags=['is_4k', 'h264', 'aac', 'audio_video', 'normal_play'])
+      tags=['is_4k', 'h264', 'aac', 'audio_video', 'normal_play'],
+      name='video.html?src=garden2_10s.mp4')
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page19(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page19, self).__init__(
       url='file://tough_video_cases/video.html?src=tulip2.ogg&type=audio&seek',
       page_set=page_set,
-      tags=['vorbis', 'audio_only', 'seek'])
+      tags=['vorbis', 'audio_only', 'seek'],
+      name='video.html?src=tulip2.ogg&type=audio&seek')
 
     self.skip_basic_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.SeekBeforeAndAfterPlayhead(action_runner)
 
 
 class Page20(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page20, self).__init__(
       url='file://tough_video_cases/video.html?src=tulip2.wav&type=audio&seek',
       page_set=page_set,
-      tags=['pcm', 'audio_only', 'seek'])
+      tags=['pcm', 'audio_only', 'seek'],
+      name='video.html?src=tulip2.wav&type=audio&seek')
 
     self.skip_basic_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.SeekBeforeAndAfterPlayhead(action_runner)
 
 
 class Page23(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page23, self).__init__(
       url='file://tough_video_cases/video.html?src=tulip2.mp3&type=audio&seek',
       page_set=page_set,
-      tags=['mp3', 'audio_only', 'seek'])
+      tags=['mp3', 'audio_only', 'seek'],
+      name='video.html?src=tulip2.mp3&type=audio&seek')
 
     self.skip_basic_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.SeekBeforeAndAfterPlayhead(action_runner)
 
 
 class Page24(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page24, self).__init__(
       url='file://tough_video_cases/video.html?src=tulip2.mp4&seek',
       page_set=page_set,
-      tags=['h264', 'aac', 'audio_video', 'seek'])
+      tags=['h264', 'aac', 'audio_video', 'seek'],
+      name='video.html?src=tulip2.mp4&seek')
 
     self.skip_basic_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.SeekBeforeAndAfterPlayhead(action_runner)
 
 
 class Page25(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page25, self).__init__(
       url='file://tough_video_cases/video.html?src=garden2_10s.webm&seek',
       page_set=page_set,
-      tags=['is_4k', 'vp8', 'vorbis', 'audio_video', 'seek'])
+      tags=['is_4k', 'vp8', 'vorbis', 'audio_video', 'seek'],
+      name='video.html?src=garden2_10s.webm&seek')
 
     self.skip_basic_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.SeekBeforeAndAfterPlayhead(action_runner)
 
 
 class Page26(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page26, self).__init__(
       url='file://tough_video_cases/video.html?src=garden2_10s.mp4&seek',
       page_set=page_set,
-      tags=['is_4k', 'h264', 'aac', 'audio_video', 'seek'])
+      tags=['is_4k', 'h264', 'aac', 'audio_video', 'seek'],
+      name='video.html?src=garden2_10s.mp4&seek')
 
     self.skip_basic_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.SeekBeforeAndAfterPlayhead(action_runner)
 
 
 class Page30(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page30, self).__init__(
       url='file://tough_video_cases/video.html?src=tulip2.vp9.webm',
       page_set=page_set,
-      tags=['vp9', 'opus', 'audio_video', 'normal_play'])
+      tags=['vp9', 'opus', 'audio_video', 'normal_play'],
+      name='video.html?src=tulip2.vp9.webm')
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page31(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page31, self).__init__(
       url='file://tough_video_cases/video.html?src=tulip2.vp9.webm&seek',
       page_set=page_set,
-      tags=['vp9', 'opus', 'audio_video', 'seek'])
+      tags=['vp9', 'opus', 'audio_video', 'seek'],
+      name='video.html?src=tulip2.vp9.webm&seek')
 
     self.skip_basic_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.SeekBeforeAndAfterPlayhead(action_runner)
 
 
 class Page32(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page32, self).__init__(
       url='file://tough_video_cases/video.html?src=crowd1080_vp9.webm',
       page_set=page_set,
-      tags=['vp9', 'video_only', 'normal_play'])
+      tags=['vp9', 'video_only', 'normal_play'],
+      name='video.html?src=crowd1080_vp9.webm')
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page33(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page33, self).__init__(
       url='file://tough_video_cases/video.html?src=crowd1080_vp9.webm&seek',
       page_set=page_set,
-      tags=['vp9', 'video_only', 'seek'])
+      tags=['vp9', 'video_only', 'seek'],
+      name='video.html?src=crowd1080_vp9.webm&seek')
 
     self.skip_basic_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.SeekBeforeAndAfterPlayhead(action_runner)
 
 
 class Page34(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page34, self).__init__(
       url='file://tough_video_cases/video.html?src=crowd720_vp9.webm',
       page_set=page_set,
-      tags=['vp9', 'video_only', 'normal_play'])
+      tags=['vp9', 'video_only', 'normal_play'],
+      name='video.html?src=crowd720_vp9.webm')
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.PlayAction(action_runner)
 
 
 class Page35(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page35, self).__init__(
       url='file://tough_video_cases/video.html?src=crowd720_vp9.webm&seek',
       page_set=page_set,
-      tags=['vp9', 'video_only', 'seek'])
+      tags=['vp9', 'video_only', 'seek'],
+      name='video.html?src=crowd720_vp9.webm&seek')
 
     self.skip_basic_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.SeekBeforeAndAfterPlayhead(action_runner)
 
 
 class Page36(ToughVideoCasesPage):
 
   def __init__(self, page_set):
     super(Page36, self).__init__(
       url=('file://tough_video_cases/video.html?src='
            'smpte_3840x2160_60fps_vp9.webm&seek'),
       page_set=page_set,
-      tags=['is_4k', 'vp9', 'video_only', 'seek'])
+      tags=['is_4k', 'vp9', 'video_only', 'seek'],
+      name=('video.html?src='
+           'smpte_3840x2160_60fps_vp9.webm&seek'))
 
     self.add_browser_metrics = True
 
   def RunPageInteractions(self, action_runner):
     self.SeekBeforeAndAfterPlayhead(action_runner,
                                     action_timeout_in_seconds=120)
 
 
 class ToughVideoCasesPageSet(story.StorySet):
   """
   Description: Video Stack Perf pages that report time_to_play, seek time and
   many other media-specific and generic metrics.
   """
   def __init__(self, measure_memory=False):
     super(ToughVideoCasesPageSet, self).__init__(
-            cloud_storage_bucket=story.PARTNER_BUCKET)
+            cloud_storage_bucket=story.PARTNER_BUCKET,
+            verify_names=True)
 
     self.measure_memory = measure_memory
 
     # Normal play tests:
     self.AddStory(Page2(self))
     self.AddStory(Page4(self))
     self.AddStory(Page7(self))
     self.AddStory(Page8(self))
     self.AddStory(Page11(self))
     self.AddStory(Page12(self))
@@ skipping 10 matching lines @@
     self.AddStory(Page19(self))
     self.AddStory(Page20(self))
     self.AddStory(Page23(self))
     self.AddStory(Page24(self))
     self.AddStory(Page25(self))
     self.AddStory(Page26(self))
     self.AddStory(Page31(self))
     self.AddStory(Page33(self))
     self.AddStory(Page35(self))
     self.AddStory(Page36(self))