Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2923363004: [Sync] Migrate bridge implementations to change list based MergeSyncData (Closed)

Created:
3 years, 6 months ago by pavely
Modified:
3 years, 6 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, sync-reviews_chromium.org, oshima+watch_chromium.org, stkhapugin, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Migrate bridge implementations to change list based MergeSyncData In the previous change (http://crrev.com/2915763005) I added version of MergeSyncData that takes EntityChangeList instead of EntityDataMap. This is needed to support bridges that can't generate storage key based on EntityData. In this change I switch already implemented bridges to the new MergeSyncData signature. MergeSyncData takes EntityChangeList where each change has type ACTION_ADD, and prepopulated storage_key. R=skym@chromium.org TBR=olivierrobin@chromium.org BUG=719570 Review-Url: https://codereview.chromium.org/2923363004 Cr-Commit-Position: refs/heads/master@{#478844} Committed: https://chromium.googlesource.com/chromium/src/+/3d6f939efc594429f36fa7ce9d2e2ebb97d34e01

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -139 lines) Patch
M chrome/browser/chromeos/printing/printers_sync_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/printing/printers_sync_bridge.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M components/autofill/core/browser/webdata/autocomplete_sync_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc View 3 chunks +4 lines, -14 lines 0 comments Download
M components/history/core/browser/typed_url_sync_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/typed_url_sync_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/reading_list/core/reading_list_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/reading_list/core/reading_list_store.h View 1 chunk +11 lines, -11 lines 0 comments Download
M components/reading_list/core/reading_list_store.cc View 2 chunks +13 lines, -14 lines 0 comments Download
M components/reading_list/core/reading_list_store_unittest.cc View 5 chunks +3 lines, -5 lines 0 comments Download
M components/sync/device_info/device_info_sync_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/device_info/device_info_sync_bridge.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/sync/device_info/device_info_sync_bridge_unittest.cc View 6 chunks +8 lines, -21 lines 0 comments Download
M components/sync/model/entity_change.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/sync/model/entity_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/model/fake_model_type_sync_bridge.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/sync/model/fake_model_type_sync_bridge.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M components/sync/model/model_type_sync_bridge.h View 1 chunk +1 line, -22 lines 0 comments Download
M components/sync/model/model_type_sync_bridge.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M components/sync/model/stub_model_type_sync_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/stub_model_type_sync_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/user_events/user_event_sync_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/user_events/user_event_sync_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
pavely
3 years, 6 months ago (2017-06-07 20:19:03 UTC) #5
skym
lgtm
3 years, 6 months ago (2017-06-08 21:10:41 UTC) #6
pavely
Adding OWNERS reviewers. PTAL skau@: chrome/browser/chromeos/printing/* rogerm@: components/autofill/core/browser/webdata/* sdefresne@: components/history/core/browser/* olivierrobin@: components/reading_list/core/*
3 years, 6 months ago (2017-06-08 23:42:22 UTC) #9
skau
chrome/browser/chromeos/printing/* lgtm
3 years, 6 months ago (2017-06-09 01:31:04 UTC) #10
sdefresne
components/history/core/browser/* lgtm
3 years, 6 months ago (2017-06-09 14:46:03 UTC) #11
Roger McFarlane (Chromium)
lgtm
3 years, 6 months ago (2017-06-11 21:33:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2923363004/1
3 years, 6 months ago (2017-06-12 23:38:27 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 00:42:53 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3d6f939efc594429f36fa7ce9d2e...

Powered by Google App Engine
This is Rietveld 408576698