components/sync/model/entity_change.h - Issue 2923363004: [Sync] Migrate bridge implementations to change list based MergeSyncData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/model/entity_change.h

Issue 2923363004: [Sync] Migrate bridge implementations to change list based MergeSyncData (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/model/entity_change.h

diff --git a/components/sync/model/entity_change.h b/components/sync/model/entity_change.h

index 65349fb6bcac27387a7b1e2246b3e1873b5325c4..408f370d54196da122bbf7feb691ded0c8e1d48c 100644

--- a/components/sync/model/entity_change.h

+++ b/components/sync/model/entity_change.h

@@ -28,10 +28,6 @@ class EntityChange {

std::string storage_key() const { return storage_key_; }

ChangeType type() const { return type_; }

const EntityData& data() const { return data_.value(); }

- // TODO(pavely): data_ptr() is added temporarily to support converting

- // ModelTypeSyncBridge::MergeSyncData from map to change list. Should be

- // removed as part of crbug.com/719570.

- const EntityDataPtr& data_ptr() const { return data_; }

private:

EntityChange(const std::string& storage_key,